Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] stock_inventory_verification_request #2131

Merged
merged 43 commits into from
Oct 22, 2024
Merged

[15.0][MIG] stock_inventory_verification_request #2131

merged 43 commits into from
Oct 22, 2024

Conversation

JoanSForgeFlow
Copy link
Contributor

Migration of the stock_inventory_verification_request to 15.0

  • Main Model Introduced: Slot Verification Request.
  • Threshold Handling: When the threshold defined in inventory adjustments is exceeded, users cannot validate the applied quantity. (This is already addressed in stock_inventory_discrepancy.)
  • Validation Process: The stock manager must handle the validation. A button will appear for the manager to create a Slot Verification Request, allowing the supervisor to review the issue later and ensure it is recorded.

@JoanSForgeFlow JoanSForgeFlow force-pushed the 15.0-mig-stock_inventory_verification_request branch 4 times, most recently from 75997a5 to 8ccfbe6 Compare August 6, 2024 09:42
LoisRForgeFlow and others added 26 commits August 6, 2024 11:44
@LoisRForgeFlow @JoanSForgeFlow
[ADD] stock_inventory_verification_request
7179443
@LoisRForgeFlow @JoanSForgeFlow
[IMP]: stock_inventory_verification_request:
14d1faa 
 * Add tests.
 * Several minor fixes.
 * Update README.
@oca-transbot @JoanSForgeFlow
OCA Transbot updated translations from Transifex
cf5a7e2
@LoisRForgeFlow @JoanSForgeFlow
[10.0][MIG] stock_inventory_verification_request
3eaea4b
@oca-transbot @JoanSForgeFlow
OCA Transbot updated translations from Transifex
b4c279a
@gurneyalex @JoanSForgeFlow
fix pylint warning and errors
9c6b513
@gurneyalex @JoanSForgeFlow
[FIX] bad inheritance declaration
b3a0f4e
@LoisRForgeFlow @JoanSForgeFlow
[11.0][MIG] stock_inventory_verification_request
303f8b0
@OCA-git-bot @JoanSForgeFlow
[UPD] README.rst
e1ad5ad
@oca-travis @JoanSForgeFlow
[UPD] Update stock_inventory_verification_request.pot
29cf2d9
@oca-transbot @JoanSForgeFlow
Update translation files
fc77200 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@osimallen @JoanSForgeFlow
[12.0][MIG]stock_inventory_verification_request migration to 12.0
01ae704
@oca-travis @JoanSForgeFlow
[UPD] Update stock_inventory_verification_request.pot
54f5f3e
@OCA-git-bot @JoanSForgeFlow
[UPD] README.rst
9f9a1c5
@oca-transbot @JoanSForgeFlow
Update translation files
29b22a1 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_inventory_verification_request
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_inventory_verification_request/
@OCA-git-bot @JoanSForgeFlow
[UPD] README.rst
424f56d
@liweijie0812 @JoanSForgeFlow
Translated using Weblate (Chinese (Simplified))
e1615b9 
Currently translated at 100.0% (60 of 60 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_inventory_verification_request
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_inventory_verification_request/zh_CN/
@marcelsavegnago @JoanSForgeFlow
Translated using Weblate (Portuguese (Brazil))
e8a3562 
Currently translated at 100.0% (60 of 60 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_inventory_verification_request
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_inventory_verification_request/pt_BR/
@MiquelRForgeFlow @JoanSForgeFlow
[IMP] category: 'Warehouse Management' -> 'Warehouse'
1545e58 
To appear in OCA shop in the good category.
@sysadminmatmoz @JoanSForgeFlow
Translated using Weblate (Slovenian)
391c059 
Currently translated at 58.3% (35 of 60 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_inventory_verification_request
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_inventory_verification_request/sl/
@AdriaGForgeFlow @JoanSForgeFlow
[12.0][IMP] stock_inventory_verification_request: set product non-req…
9792afd 
…uired and add slot_verification_ids to stock.location model

[ADD] button to create inventory adjustment from slot verification request

[FIX] slot verification request menu position
@LoisRForgeFlow @JoanSForgeFlow
[IMP] stock_verification_request: add search view to improve usability
532f833
@LoisRForgeFlow @JoanSForgeFlow
[12.0][IMP] stock_inventory_verification_request:
5aa2f6d 
* link to created inv. adjustments
* add _descrition
@LoisRForgeFlow @JoanSForgeFlow
[12.0][IMP] stock_inventory_verification_request:
d7b9a70 
* track changes in some fields.
* make product and location only editable in 'wait' state.
@AdriaGForgeFlow @JoanSForgeFlow
[12.0][IMP] stock_inventory_verification_request: support multi-compa…
6beea72 
…ny setup
@oca-travis @JoanSForgeFlow
[UPD] Update stock_inventory_verification_request.pot
507805f
@JoanSForgeFlow JoanSForgeFlow force-pushed the 15.0-mig-stock_inventory_verification_request branch 3 times, most recently from 7e2577b to f19cc5d Compare August 6, 2024 10:43
@JoanSForgeFlow JoanSForgeFlow force-pushed the 15.0-mig-stock_inventory_verification_request branch from f19cc5d to 6914ac4 Compare August 27, 2024 10:26
@JoanSForgeFlow JoanSForgeFlow force-pushed the 15.0-mig-stock_inventory_verification_request branch 2 times, most recently from 44cbd5f to 76043b1 Compare October 8, 2024 07:34
@rousseldenis
Copy link
Contributor

/ocabot migration stock_inventory_verification_request

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Oct 8, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 8, 2024
Open
80 tasks
rousseldenis
rousseldenis reviewed Oct 8, 2024
View reviewed changes
stock_inventory_verification_request/models/stock_inventory.py Outdated
"lot_id": quant.lot_id.id if quant.lot_id else False,
}
)
self.requested_verification = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quant.requested_verification = True

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And add : return {"type": "ir.actions.act_window_close"} which is more correct syntaxically.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for yours comments, we have applied the changes.

rousseldenis
rousseldenis requested changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoanSForgeFlow No migration script for the requested_verification field ?

stock_inventory_verification_request/models/stock_inventory.py Outdated
"lot_id": quant.lot_id.id if quant.lot_id else False,
}
)
self.requested_verification = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And add : return {"type": "ir.actions.act_window_close"} which is more correct syntaxically.

@JoanSForgeFlow
Copy link
Contributor Author

Hello @rousseldenis

I think it doesn't make much sense to create a migration script for this, right? After all, it's just a field used to mark that a review is in progress.

But from 12.0 to 15.0, the adjustments flow have changed a lot technically. Previously, this field was in stock.inventory, and stock.inventory had stock.inventory.lines. Now, this field is in stock.quant. So, what would need to be done is to check which stock.inventory you have with requested_verification set to True in 12.0 and look at which lines you have with which products and where, and then make the equivalence to set those quants to True.

I think it's an effort that isn't worth it, right? Better before migrating closing the SVRs and start in 15.0 with all quants in requested=False.

Thank you

@ThiagoMForgeFlow ThiagoMForgeFlow force-pushed the 15.0-mig-stock_inventory_verification_request branch from 76043b1 to e126038 Compare October 17, 2024 09:20
rousseldenis
rousseldenis approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoanSForgeFlow JoanSForgeFlow force-pushed the 15.0-mig-stock_inventory_verification_request branch from e126038 to 0eba1ac Compare October 22, 2024 08:24
LoisRForgeFlow
LoisRForgeFlow approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-2131-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a584912 into OCA:15.0 Oct 22, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1f0c538. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 15.0-mig-stock_inventory_verification_request branch October 22, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThiagoMForgeFlow ThiagoMForgeFlow ThiagoMForgeFlow left review comments

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.