Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] stock_change_qty_reason #1854

Closed

Conversation

paradoxxxzero
Copy link

@paradoxxxzero paradoxxxzero commented Sep 28, 2023

Superseeds #1674

Fix UI view for stock.quant.reason (fix button box, remove extraneous attributes and add explicit label):

20230928_11h35m34s_grim

Also remove past migrations, and improve comments.

rousseldenis and others added 30 commits September 28, 2023 10:13
Currently translated at 96.2% (25 of 26 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_change_qty_reason
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_change_qty_reason/fr/
Currently translated at 100.0% (26 of 26 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_change_qty_reason
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_change_qty_reason/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-13.0/stock-logistics-warehouse-13.0-stock_change_qty_reason
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-13-0/stock-logistics-warehouse-13-0-stock_change_qty_reason/
Currently translated at 100.0% (25 of 25 strings)

Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_change_qty_reason
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_change_qty_reason/it/
Also remove past migrations, and improve comments
@rousseldenis
Copy link
Contributor

/ocabot migration stock_change_qty_reason

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 9, 2023
@OCA-git-bot
Copy link
Contributor

The migration issue (#1494) has not been updated to reference the current pull request because a previous pull request (#1674) is not closed.
Perhaps you should check that there is no duplicate work.
CC @Urvisha-OSI

@rousseldenis
Copy link
Contributor

/ocabot migration stock_change_qty_reason

@rousseldenis
Copy link
Contributor

@paradoxxxzero Thanks for this. Maybe could you split your changes not related to button box commit either in migration commit, either in a new one ? Thanks

Comment on lines +11 to +34
<field name="reason" />
</field>
</field>
</record>
<record id="preset_reason_view_move_line_tree" model="ir.ui.view">
<field name="name">stock.move.line.tree</field>
<field name="model">stock.move.line</field>
<field name="inherit_id" ref="reason_view_move_line_tree" />
<field name="priority">99</field>
<field name="arch" type="xml">
<field name="reason" position="after">
<field
name="preset_reason_id"
string="Reason"
groups="stock_change_qty_reason.group_qty_reason_preset"
/>
</field>
<xpath expr="//field[@name='reason']" position="attributes">
<t groups="stock_change_qty_reason.group_qty_reason_preset">
<attribute name="invisible">True</attribute>
</t>
</xpath>
</field>
</record>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just use like this instead of adding new inherited view?

Suggested change
<field name="reason" />
</field>
</field>
</record>
<record id="preset_reason_view_move_line_tree" model="ir.ui.view">
<field name="name">stock.move.line.tree</field>
<field name="model">stock.move.line</field>
<field name="inherit_id" ref="reason_view_move_line_tree" />
<field name="priority">99</field>
<field name="arch" type="xml">
<field name="reason" position="after">
<field
name="preset_reason_id"
string="Reason"
groups="stock_change_qty_reason.group_qty_reason_preset"
/>
</field>
<xpath expr="//field[@name='reason']" position="attributes">
<t groups="stock_change_qty_reason.group_qty_reason_preset">
<attribute name="invisible">True</attribute>
</t>
</xpath>
</field>
</record>
<field name="reason" groups="!stock_change_qty_reason.group_qty_reason_preset"/>
<field
name="preset_reason_id"
string="Reason"
groups="stock_change_qty_reason.group_qty_reason_preset"
/>
</field>
</field>
</record>

Copy link

github-actions bot commented Jun 9, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 9, 2024
@github-actions github-actions bot closed this Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.