Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] stock_available_mrp: variant BoMs #17

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

danielduqma
Copy link

When a BoM is linked just to one variant through field product_id, it is taken in account when computing stock of the rest of variants of the same template.

AFAIK, there are two ways to link a BoM to a specific variant:

  • Having one for the whole template, and linking attribute values to components with field bom_product_template_attribute_value_ids
  • Linking a BoM to a variant with field product_id

The first one works right, but the second one can make a variant take in account a BoM that is linked to another variant of its template, so stock computations are not right.

@danielduqma danielduqma changed the title [FIX] stock_available_mrp: variant BoMs [16.0][FIX] stock_available_mrp: variant BoMs Dec 12, 2023
@danielduqma danielduqma marked this pull request as ready for review December 12, 2023 11:15
@pedrobaeza pedrobaeza added this to the 16.0 milestone Dec 12, 2023
@danielduqma danielduqma force-pushed the 16.0-fix-stock_available_mrp branch from 6bf6174 to d56c63e Compare December 28, 2023 13:13
@danielduqma danielduqma force-pushed the 16.0-fix-stock_available_mrp branch from d56c63e to 85bf94a Compare April 10, 2024 09:00
@danielduqma danielduqma force-pushed the 16.0-fix-stock_available_mrp branch from 85bf94a to be78a32 Compare May 24, 2024 11:52
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 22, 2024
@ACheung-FactorLibre ACheung-FactorLibre force-pushed the 16.0-fix-stock_available_mrp branch 3 times, most recently from e7d0d9c to d3452ab Compare December 9, 2024 11:10
When a BoM is linked just to one variant through field `product_id`,
it is taken in account when computing stock of the rest of variants
of the same template.
@danielduqma danielduqma force-pushed the 16.0-fix-stock_available_mrp branch from d3452ab to cd0eeb9 Compare December 9, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants