-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] stock_available_location_get_domain #11
base: 16.0
Are you sure you want to change the base?
[16.0][ADD] stock_available_location_get_domain #11
Conversation
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Is this feature available for v.15 too? |
@Sridharksolves Not yet. But if we merge this, we can backport. Could you review this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Code review + Functional tests) Works in production for months
field = leaf.split(".")[0] | ||
if field in location_fields and field != "location_id": | ||
location_domain.append(element) | ||
elif field == "location_id": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You miss the use case where the leaf is just "location_id"
elif field == "location_id": | |
elif leaf == "location_id": | |
location_domain.append(("id", element[1], element[2])) | |
elif field == "location_id": |
location_fields = self.env["stock.location"].fields_get() | ||
for element in quant_domain: | ||
leaf = expression.is_leaf(element) | ||
if leaf: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leaf can also be a boolean
if leaf: | |
if leaf and isinstance(leaf, str): |
@jbaudoux Thanks for review. I will add those cases. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
No description provided.