[18.0][MIG] bi_sql_editor: Migration to 18.0 #938

thienvh332 · 2024-10-10T04:24:32Z

Ported PRs

Depend on:

[18.0][MIG] sql_request_abstract: Migration to 18.0 #937

henrybackman

Small change requests but overall looks good 👍

bi_sql_editor/models/bi_sql_view_field.py

bi_sql_editor/models/bi_sql_view.py

bi_sql_editor/views/view_bi_sql_view.xml

sebalix

LG, small remarks

bi_sql_editor/models/bi_sql_view.py

JrAdhoc

LGTM

sebalix · 2024-11-28T18:00:07Z

Hello @thienvh332 , you can drop your DON'T MERGE commit, all dependencies have been merged now :) Thanks!

…ield; [ADD] security

…fresh date time on the action name of each sql materialized view

Fix error '... is not a table or foreign table' Fix view (colors + oe_highlight) Fix tests Fix README + manifest Fix back to draft Fix cron call + default values Use Postgres version 9.6 for travis builds

* [IMP] is_materialized field non readonly on sql_valid state ; [FIX] block possibility to set indexes on non materialized view * [FIX] set domain_force, group_ids readonly if state > sql_valid * [IMP] better display of the field group_ids * [IMP] possibility to reorder menu items from sql views * [IMP] Do not warn user when setting sql view to draft if state is sql_valid * [REF] * [FIX] Set Date of the first execution in the action name

…le to implement that feature with optional='hide' on the field list view

…del Valid'. Avoid to reset to draft and to have to recreate view that can take a while, if the view is materialized

…on field items

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-17.0/reporting-engine-17.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-bi_sql_editor/

Currently translated at 100.0% (140 of 140 strings) Translation: reporting-engine-17.0/reporting-engine-17.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-bi_sql_editor/es/

Currently translated at 19.2% (27 of 140 strings) Translation: reporting-engine-17.0/reporting-engine-17.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-bi_sql_editor/it/

Currently translated at 100.0% (140 of 140 strings) Translation: reporting-engine-17.0/reporting-engine-17.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-bi_sql_editor/it/

…ating UI elements When creating the UI for the SQL view, it is now possible to set a specific Parent Menu which will be used when creating the UI Menu for the report itself. The default value will be the `SQL Reports` menu. Also, added the explanation on the `CONFIGURE.rst` file to have the description updated.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-17.0/reporting-engine-17.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-bi_sql_editor/

Currently translated at 100.0% (144 of 144 strings) Translation: reporting-engine-17.0/reporting-engine-17.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-bi_sql_editor/it/

Currently translated at 100.0% (144 of 144 strings) Translation: reporting-engine-17.0/reporting-engine-17.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-bi_sql_editor/sv/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-17.0/reporting-engine-17.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-bi_sql_editor/

Allow to call refresh materialized view with an explicit lang passed in the context and have this get priority over the user's lang

thienvh332 · 2024-11-29T05:23:53Z

you can drop your DON'T MERGE commit, all dependencies have been merged now :) Thanks!

Hi @sebalix ,
Thanks, I updated it.

sebalix

Getting back on my review, I couldn't create SQL objects on a demo report (on runbot):

Can you check this please?

henrybackman suggested changes Oct 23, 2024

View reviewed changes

bi_sql_editor/models/bi_sql_view_field.py Outdated Show resolved Hide resolved

bi_sql_editor/models/bi_sql_view.py Outdated Show resolved Hide resolved

bi_sql_editor/models/bi_sql_view.py Outdated Show resolved Hide resolved

bi_sql_editor/views/view_bi_sql_view.xml Show resolved Hide resolved

thienvh332 force-pushed the 18.0-mig-bi_sql_editor branch 2 times, most recently from 3acc48a to 213c15c Compare October 24, 2024 04:12

thienvh332 requested a review from henrybackman October 25, 2024 05:34

sebalix reviewed Oct 28, 2024

View reviewed changes

bi_sql_editor/models/bi_sql_view.py Outdated Show resolved Hide resolved

bi_sql_editor/models/bi_sql_view.py Outdated Show resolved Hide resolved

bi_sql_editor/models/bi_sql_view.py Outdated Show resolved Hide resolved

thienvh332 force-pushed the 18.0-mig-bi_sql_editor branch 2 times, most recently from aa72ab4 to 9753795 Compare October 29, 2024 05:26

thienvh332 requested a review from sebalix October 29, 2024 05:31

lef-adhoc approved these changes Oct 31, 2024

View reviewed changes

JrAdhoc approved these changes Oct 31, 2024

View reviewed changes

henrybackman approved these changes Nov 4, 2024

View reviewed changes

OCA-git-bot added the approved label Nov 4, 2024

legalsylvain and others added 17 commits November 29, 2024 10:58

new module bi_sql_editor [IMP] function to guess model for many2one f…

efd7b95

…ield; [ADD] security

OCA Transbot updated translations from Transifex

0c462d8

bi_sql_editor

b9a4e87

create ui now create tree view [IMP] fr translation [IMP] add last re…

54f1dd0

…fresh date time on the action name of each sql materialized view

[IMP] Add test + several fixes

f410135

OCA Transbot updated translations from Transifex

d6c4dcb

FIX bi_sql_editor

37f8829

[MIG] bi_sql_editor v10

9bfe61f

[IMP] preview button

8b40868

Fix several issues

3e67a99

Fix error '... is not a table or foreign table' Fix view (colors + oe_highlight) Fix tests Fix README + manifest Fix back to draft Fix cron call + default values Use Postgres version 9.6 for travis builds

[UPD] Update bi_sql_editor.pot

9a2391e

[MIG] bi_sql_editor: Migration to 11.0

7def61e

[FIX] Can be upgraded with materialized views generated

ecc0d50

[FIX] ir.cron relation

e78911e

[IMP] remove unneeded parenthesis

a8122e2

[FIX] Solves the upgrading problem

4673cdf

legalsylvain and others added 25 commits November 29, 2024 10:59

[REM] bi_sql_editor : option_context_field field, as it is now possib…

fc26105

…le to implement that feature with optional='hide' on the field list view

[IMP] bi_sql_editor : Allow to change fields settings if state is 'Mo…

5fb9253

…del Valid'. Avoid to reset to draft and to have to recreate view that can take a while, if the view is materialized

[IMP] bi_sql_editor : Improve code coverage, adding various settings …

b7d0201

…on field items

[MIG] bi_sql_editor: Migration to 17.0

e51ac73

[UPD] Update bi_sql_editor.pot

f082b49

[BOT] post-merge updates

17c0cbb

Translated using Weblate (Spanish)

f7f371d

Currently translated at 100.0% (140 of 140 strings) Translation: reporting-engine-17.0/reporting-engine-17.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-bi_sql_editor/es/

Translated using Weblate (Italian)

f99583c

Currently translated at 19.2% (27 of 140 strings) Translation: reporting-engine-17.0/reporting-engine-17.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-bi_sql_editor/it/

Translated using Weblate (Italian)

45a8dd2

Currently translated at 100.0% (140 of 140 strings) Translation: reporting-engine-17.0/reporting-engine-17.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-bi_sql_editor/it/

Translated using Weblate (Italian)

5bebd85

Currently translated at 100.0% (140 of 140 strings) Translation: reporting-engine-17.0/reporting-engine-17.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-bi_sql_editor/it/

[FIX] *: line too long

f562c25

[BOT] post-merge updates

fbbf8ac

[UPD] Update bi_sql_editor.pot

44bd004

[BOT] post-merge updates

34f89cf

Translated using Weblate (Italian)

7e763c4

Currently translated at 100.0% (144 of 144 strings) Translation: reporting-engine-17.0/reporting-engine-17.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-bi_sql_editor/it/

Translated using Weblate (Swedish)

c1853ef

Currently translated at 100.0% (144 of 144 strings) Translation: reporting-engine-17.0/reporting-engine-17.0-bi_sql_editor Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-bi_sql_editor/sv/

[UPD] Update bi_sql_editor.pot

176fd92

IMP: bi_sql_editor lang

68c1980

Allow to call refresh materialized view with an explicit lang passed in the context and have this get priority over the user's lang

[IMP] pre-commit lint

2ab8389

[MIG] bi_sql_editor: Migration to 18.0

bdd4c03

thienvh332 force-pushed the 18.0-mig-bi_sql_editor branch from 9753795 to bdd4c03 Compare November 29, 2024 03:59

sebalix approved these changes Nov 29, 2024

View reviewed changes

sebalix added this to the 18.0 milestone Nov 29, 2024

sebalix reviewed Nov 29, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] bi_sql_editor: Migration to 18.0 #938

[18.0][MIG] bi_sql_editor: Migration to 18.0 #938

thienvh332 commented Oct 10, 2024

henrybackman left a comment

sebalix left a comment

JrAdhoc left a comment

sebalix commented Nov 28, 2024

thienvh332 commented Nov 29, 2024

sebalix left a comment

[18.0][MIG] bi_sql_editor: Migration to 18.0 #938

Are you sure you want to change the base?

[18.0][MIG] bi_sql_editor: Migration to 18.0 #938

Conversation

thienvh332 commented Oct 10, 2024

Ported PRs

Depend on:

henrybackman left a comment

Choose a reason for hiding this comment

sebalix left a comment

Choose a reason for hiding this comment

JrAdhoc left a comment

Choose a reason for hiding this comment

sebalix commented Nov 28, 2024

thienvh332 commented Nov 29, 2024

sebalix left a comment

Choose a reason for hiding this comment