-
-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] report_xlsx: Save as attachment #767
Conversation
b2e72f7
to
0e2b71a
Compare
I'm not entirely sure whether this is a FIX or IMProvement - leaning towards FIX as the field is there in the current version but not working as expected. |
Hi @OCA/reporting-engine-maintainers this PR is ready, please review |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Hi this PR is becoming stale @RodrigoBM @AntoniRomera @FernandoRomera @pedrobaeza @alexis-via I'm pinging you as you worked on 16.0 mig in #690 Thanks |
can @houzefa-abba rebase? |
This implements behavior expected when configuring "Save as Attachment Prefix" within xlsx reports.
0e2b71a
to
62b5a71
Compare
Rebase done, I checked on runboat, this is still working fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge major
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at ac3a358. Thanks a lot for contributing to OCA. ❤️ |
This implements behavior expected when configuring "Save as Attachment Prefix" within xlsx reports.
Also adds a unit test to check this.
To try it by hand:
Before this commit, no files would be saved within attachments.