Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] report_xlsx: Save as attachment #767

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

houzefa-abba
Copy link
Member

This implements behavior expected when configuring "Save as Attachment Prefix" within xlsx reports.

Also adds a unit test to check this.

To try it by hand:

  • In a report > "Advanced Properties" tab, configure the field:
    Screenshot at 2023-06-06 17-01-20
  • Click "Add to the print menu"
  • From a record said report is for, produce a report via "Print" menu and observe attachment getting added within mail thread:
    Screenshot at 2023-06-06 17-03-41

Before this commit, no files would be saved within attachments.

@houzefa-abba houzefa-abba changed the title report_xlsx: Save as attachment [16.0][FIX] report_xlsx: Save as attachment Jun 6, 2023
@houzefa-abba
Copy link
Member Author

I'm not entirely sure whether this is a FIX or IMProvement - leaning towards FIX as the field is there in the current version but not working as expected.

@houzefa-abba
Copy link
Member Author

Hi @OCA/reporting-engine-maintainers this PR is ready, please review

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 8, 2023
@houzefa-abba
Copy link
Member Author

Hi this PR is becoming stale

@RodrigoBM @AntoniRomera @FernandoRomera @pedrobaeza @alexis-via I'm pinging you as you worked on 16.0 mig in #690

Thanks

@RodrigoBM
Copy link
Contributor

can @houzefa-abba rebase?

@pedrobaeza pedrobaeza added this to the 16.0 milestone Oct 9, 2023
This implements behavior expected when configuring "Save as Attachment Prefix"
within xlsx reports.
@houzefa-abba
Copy link
Member Author

can @houzefa-abba rebase?

Rebase done, I checked on runboat, this is still working fine

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-767-by-pedrobaeza-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5fe3a6e into OCA:16.0 Oct 10, 2023
4 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ac3a358. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants