From fecc083238abca2f2d3742c6487e863ac3888b23 Mon Sep 17 00:00:00 2001
From: Maksym Yankin <yankinmk@gmail.com>
Date: Thu, 19 Oct 2023 17:45:52 +0300
Subject: [PATCH] [IMP] bi_view_editor: Restrict access to BI View Editor
 Managers

---
 bi_view_editor/__manifest__.py              |  1 +
 bi_view_editor/readme/USAGE.rst             |  3 +++
 bi_view_editor/security/ir.model.access.csv |  6 ++++--
 bi_view_editor/security/res_groups.xml      | 14 ++++++++++++++
 bi_view_editor/views/bve_view.xml           |  6 +++++-
 5 files changed, 27 insertions(+), 3 deletions(-)
 create mode 100644 bi_view_editor/security/res_groups.xml

diff --git a/bi_view_editor/__manifest__.py b/bi_view_editor/__manifest__.py
index dd4ecf602b..609e912594 100644
--- a/bi_view_editor/__manifest__.py
+++ b/bi_view_editor/__manifest__.py
@@ -16,6 +16,7 @@
         "deb": ["graphviz"],
     },
     "data": [
+        "security/res_groups.xml",
         "security/ir.model.access.csv",
         "security/rules.xml",
         "views/bve_view.xml",
diff --git a/bi_view_editor/readme/USAGE.rst b/bi_view_editor/readme/USAGE.rst
index 064ab5610c..607e838395 100644
--- a/bi_view_editor/readme/USAGE.rst
+++ b/bi_view_editor/readme/USAGE.rst
@@ -1,6 +1,8 @@
 To graphically design your analysis data-set:
 
 - From the Dashboards menu, select "Custom BI Views"
+- BI Views creation is restricted to members of "BI View Editor Manager" group.
+  You can add this group to a user in User form, Access Rights, Technical section.
 - Browse trough the business objects in the "Query Builder" tab
 - Pick the interesting fields (Drag & Drop)
 - For each selected field, right-click on the Options column and select whether
@@ -13,6 +15,7 @@ To access the created BI View with a dedicated menu:
 
 - If module Dashboard (board) is installed, the standard "Add to My Dashboard"
   functionality would be available
+- "Create a menu" is restricted to members of "BI View Editor Manager" group.
 - Click "Create a menu" to create a new menu item directly linked to your new
   BI view (this feature is available in developer mode); when the BI view is
   reset back to draft this menu will be removed, and you will need to re-create
diff --git a/bi_view_editor/security/ir.model.access.csv b/bi_view_editor/security/ir.model.access.csv
index dd6cc2dafd..b45744f746 100644
--- a/bi_view_editor/security/ir.model.access.csv
+++ b/bi_view_editor/security/ir.model.access.csv
@@ -1,3 +1,5 @@
 id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
-access_bve_view_everyone,bve.view,bi_view_editor.model_bve_view,,1,1,1,1
-access_bve_view_line,access_bve_view_line,model_bve_view_line,,1,1,1,1
+access_bve_view_everyone_user,bve.view.user,bi_view_editor.model_bve_view,base.group_user,1,0,0,0
+access_bve_view_everyone_manager,bve.view.manager,bi_view_editor.model_bve_view,bi_view_editor.group_bve_manager,1,1,1,1
+access_bve_view_line_user,access_bve_view_line_user,bi_view_editor.model_bve_view_line,base.group_user,1,0,0,0
+access_bve_view_line_manager,access_bve_view_line_manager,bi_view_editor.model_bve_view_line,bi_view_editor.group_bve_manager,1,1,1,1
diff --git a/bi_view_editor/security/res_groups.xml b/bi_view_editor/security/res_groups.xml
new file mode 100644
index 0000000000..fea03c8b35
--- /dev/null
+++ b/bi_view_editor/security/res_groups.xml
@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<odoo noupdate="1">
+
+    <record id="group_bve_manager" model="res.groups">
+        <field name="name">BI View Editor Manager</field>
+        <field name="category_id" ref="base.module_category_hidden" />
+        <field name="implied_ids" eval="[(4, ref('base.group_user'))]" />
+        <field
+            name="users"
+            eval="[(4, ref('base.user_root')), (4, ref('base.user_admin'))]"
+        />
+    </record>
+
+</odoo>
diff --git a/bi_view_editor/views/bve_view.xml b/bi_view_editor/views/bve_view.xml
index 0dfcdf8c10..d67d7b8155 100644
--- a/bi_view_editor/views/bve_view.xml
+++ b/bi_view_editor/views/bve_view.xml
@@ -18,6 +18,7 @@
                         type="object"
                         states="created"
                         string="Reset to Draft"
+                        groups="bi_view_editor.group_bve_manager"
                     />
                     <button
                         name="action_create"
@@ -25,6 +26,7 @@
                         states="draft"
                         string="Generate BI View"
                         class="oe_highlight"
+                        groups="bi_view_editor.group_bve_manager"
                     />
                     <button
                         name="open_view"
@@ -32,12 +34,13 @@
                         states="created"
                         string="Open BI View"
                         class="oe_highlight"
+                        groups="bi_view_editor.group_bve_manager"
                     />
                     <button
                         name="%(base.act_menu_create)d"
                         type="action"
                         states="created"
-                        groups="base.group_no_one"
+                        groups="bi_view_editor.group_bve_manager"
                         icon="fa-align-justify"
                         string="Create a Menu"
                         target="new"
@@ -57,6 +60,7 @@
                             states="created"
                             icon="fa-globe"
                             string="Translations"
+                            groups="bi_view_editor.group_bve_manager"
                         />
                     </div>
                     <h1>