From c03e250762860a21bd1a0f8925e3901e987d06af Mon Sep 17 00:00:00 2001 From: sbejaoui Date: Fri, 30 Apr 2021 15:23:17 +0200 Subject: [PATCH] [IMP] - use display for element visibility the visibility attribute with the hidden option hides the element but don't free the space. A common use case is to have a specific header for the first page and another for the other pages. With visibility: hidden the second header cannot take the first one place and will keep a huge margin. One solution is to use the display:none instead. --- report_qweb_element_page_visibility/views/layouts.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/report_qweb_element_page_visibility/views/layouts.xml b/report_qweb_element_page_visibility/views/layouts.xml index 823d1cad1a..d989566a31 100644 --- a/report_qweb_element_page_visibility/views/layouts.xml +++ b/report_qweb_element_page_visibility/views/layouts.xml @@ -33,16 +33,16 @@ var operations = { 'not-first-page': function (elt) { - elt.style.visibility = (vars.sitepage == vars.frompage) ? "hidden" : "visible"; + elt.style.display = (vars.sitepage === vars.frompage) ? "none" : "inherit"; }, 'not-last-page': function (elt) { - elt.style.visibility = (vars.sitepage == vars.sitepages) ? "hidden" : "visible"; + elt.style.display = (vars.sitepage === vars.sitepages) ? "none" : "inherit"; }, 'first-page': function (elt) { - elt.style.visibility = (vars.sitepage == vars.frompage) ? "visible" : "hidden"; + elt.style.display = (vars.sitepage === vars.frompage) ? "inherit" : "none"; }, 'last-page': function (elt) { - elt.style.visibility = (vars.sitepage == vars.sitepages) ? "visible" : "hidden"; + elt.style.display = (vars.sitepage === vars.sitepages) ? "inherit" : "none"; }, 'single-page': function (elt) { elt.style.display = (vars.sitepages === 1) ? "inherit" : "none";