-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] base_report_to_printer_mail: Migration to 16.0 #333
[16.0][MIG] base_report_to_printer_mail: Migration to 16.0 #333
Conversation
6267fdd
to
68f96ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. You would need to squash the commits as indicated in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests
68f96ba
to
ace74b7
Compare
Hi @BT-anieto , I updated |
@@ -0,0 +1 @@ | |||
../../../../base_report_to_printer_mail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change related to setup
folder are also normally part of the [IMP] $module: pre-commit stuff
if you follow the OCA migration guidelines: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0#technical-method-to-migrate-a-module-from-150-to-160-branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for your review, I updated
This PR has the |
ace74b7
to
2258631
Compare
@QuocDuong1306 thank you! /ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 5034bed. Thanks a lot for contributing to OCA. ❤️ |
Depend on #332