pre-commit/mirrors-prettier has been archived

[sbidoul]

The https://github.com/pre-commit/mirrors-prettier repo has been archived without much explanation.

There is some discussion in prettier/prettier#15742

We may need to look for an alternative.

[PabloEForgeFlow]

I was looking at some of the proposed solutions in the discussion, and using local hooks (prettier/prettier#15742 (comment)) seems quite reasonable to me. We would need to pull in all the keys from .pre-commit-hooks.yaml, but I think it's simple enough that it shouldn't be a problem.

We could perhaps do the same for eslint and remove the dependency on the repo, in case something similar happens to it.

[sbidoul]

@PabloEForgeFlow that sounds worth trying, yes.

[PabloEForgeFlow]

Good to hear, I'll get something working and do a PR.

We will probably want to update the version for both of them in v18 right? They've both had new major versions with breaking changes (prettier in v3.0.0 and eslint in v9.0.0), so I'm not sure if we should only update to the latest minor version.

[sbidoul]

Yes let's use the latest versions in 18. If we don't wait too much, we can still push it to the 18.0 branches. The more we wait, the more we risk making branches red and create trouble for maintainers, though.

[PabloEForgeFlow]

@sbidoul Hey Stéphane, could you take a look at #278?

[sbidoul]

Yes yes, it's on my radar 😓

[PabloEForgeFlow]

Yes yes, it's on my radar 😓

Sorry, I didn't mean to pressure you. I thought the notification might have gotten lost among the many things that are going on. 🙇

[sbidoul]

No worries :) I made a couple of quick comments, and I'll try to test this week still.