Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] [IMP] l10n_it_delivery_note: delivery note company field adjustments #3919

Merged
merged 1 commit into from
Feb 1, 2024
Merged

[14.0] [IMP] l10n_it_delivery_note: delivery note company field adjustments #3919

merged 1 commit into from
Feb 1, 2024

Conversation

renda-dev
Copy link
Contributor

  • Moved company_id under transport_datetime
  • Filter domain on user's enabled companies

@OCA-git-bot
Copy link
Contributor

Hi @MarcoCalcagni, @aleuffre,
some modules you are maintaining are being modified, check this out!

aleuffre
aleuffre approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

francesco-ooops
francesco-ooops approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funzionale ok

  • sistemato comportamento multicompany per creare DN solo per company attive
  • spostato campo company nella form DN per maggiore chiarezza dei campi da selezionare

@francesco-ooops francesco-ooops mentioned this pull request Jan 31, 2024
Closed
2 tasks
@francesco-ooops francesco-ooops linked an issue Jan 31, 2024 that may be closed by this pull request
l10n_it_delivery_note: delivery note company field adjustments #3920
Closed
2 tasks
@aleuffre
Copy link
Contributor

aleuffre commented Feb 1, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-3919-by-aleuffre-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a7a2069 into OCA:14.0 Feb 1, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a2edccb. Thanks a lot for contributing to OCA. ❤️

@aleuffre aleuffre deleted the 14.0-imp-l10n_it_delivery_note-company branch February 1, 2024 09:29
@PicchiSeba PicchiSeba mentioned this pull request Feb 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleuffre aleuffre aleuffre approved these changes

@francesco-ooops francesco-ooops francesco-ooops approved these changes

Assignees
No one assigned
Labels
14.0 approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

l10n_it_delivery_note: delivery note company field adjustments
4 participants
@renda-dev @OCA-git-bot @aleuffre @francesco-ooops