Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][l10n_fr_department] improve search res_partner by department #575

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][l10n_fr_department] improve search res_partner by department #575

wants to merge 1 commit into from

Conversation

clementelabore
Copy link

added _name_search in res.country.department, to filter partner by departments

@OCA-git-bot
Copy link
Contributor

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

@legalsylvain
Copy link
Contributor

Hi clement, could you elaborate which kind of search your PR is allowing ? I'm not sure to understand.

thanks !

@clementelabore
Copy link
Author

With my PR, in Contacts, you can search contacts by departments.
Ex : You can search :

  • "03" => Only Contacts in "Allier (03)"
  • Allier => Only Contacts in "Allier (03)"
  • "Allier (03)" => Only Contacts in "Allier (03)"
  • Futhermore advanced filters on department works "department not equal 03" for example

@clementelabore
Copy link
Author

hi @legalsylvain can you validate my PR ? Thx.

legalsylvain
legalsylvain reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's dangerous to not call _name_search in the _name_search function.

_name_search should always call super, to avoid to break inheritance mechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clementelabore @OCA-git-bot @legalsylvain @clementthomas