Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to version 18.0 #573

Open
17 tasks
OCA-git-bot opened this issue Oct 6, 2024 · 4 comments
Open
17 tasks

Migration to version 18.0 #573

OCA-git-bot opened this issue Oct 6, 2024 · 4 comments
Labels
help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress
Milestone

Comments

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Oct 6, 2024

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

Modules to migrate

  • account_banking_fr_lcr
  • l10n_fr_account_invoice_facturx
  • l10n_fr_account_tax_unece
  • l10n_fr_chorus_account
  • l10n_fr_chorus_facturx
  • l10n_fr_chorus_sale
  • l10n_fr_cog
  • l10n_fr_das2
  • l10n_fr_department
  • l10n_fr_department_oversea
  • l10n_fr_hr_check_ssnid
  • l10n_fr_intrastat_product
  • l10n_fr_intrastat_service
  • l10n_fr_pos_caisse_ap_ip
  • l10n_fr_siret - By @fredericgrall - 18.0 mig l10n fr siret #578
  • l10n_fr_siret_lookup - By @fredericgrall - 18.0 mig l10n fr siret lookup #579
  • l10n_fr_state

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

@OCA-git-bot OCA-git-bot added help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress labels Oct 6, 2024
@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 6, 2024
@alexis-via
Copy link
Contributor

Following a discusson at Odoo Experience, we plan to adopt another method on the 18.0 branch: push the 17.0 branch with modules marked as installable=False (while keeping the config files of the 18.0 branch). It has many advantages: lighter branches, easier migration PR and several OCA projects have gone back to this good old method (for example : OCA/mis-builder).
If you disagree with this, give your reasons here before tonight!

@pedrobaeza
Copy link
Member

I don't see it as an advantage, as there may be missing commits from the previous branch (17.0 in this case) in the moment of migrating a module (because between the moment creating the 18.0 branch from 17.0) till the moment of migrating the module, other commits may enter in the previous branch, and thus, not being aware of them. The other method is always the same for getting the latest commit history.

It also pollutes the commit history with commits doing/undoing things, and provoke conflicts, as non installable modules create an entry on the pre-commit config file (example: https://github.com/OCA/mis-builder/blob/a4796288344b4ada3ea77e1d810221696f98449a/.pre-commit-config.yaml#L4), and each time you merge a migration PR, it may require a rebase on all the other PRs fixing the conflict.

Only mis-builder and queue repos are using them. I totally dislike such technique, but it's more reasonable on that repos, which have very few modules. Applying it to repos like this with a lot of modules will cause several troubles.

Anyway, I don't have vote here, but just for letting you know the disadvantages for taking an informed decision.

@fredericgrall
Copy link

l10n fr siret #578

@fredericgrall
Copy link

l10n fr siret lookup #579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress
Projects
None yet
Development

No branches or pull requests

4 participants