[14.0][FIX] l10n_br_purchase: fix purchase order line form button 'save and new' #3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
é bom rodar o pre-commit run ai localmente |
WesleyOliveira98
force-pushed
the
14.0-l10n_br_purchase-fix-order-line-save-and-new-btn
branch
from
7959a48
to
854600a
Compare
|
@kaynnan pode simular o comportamento atual e revisar funcional/tecnico a PR ? |
kaynnan
approved these changes
May 20, 2024
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 853f539. Thanks a lot for contributing to OCA. ❤️ |
marcelsavegnago
deleted the
14.0-l10n_br_purchase-fix-order-line-save-and-new-btn
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essa PR visa resolver a Issue #3057
No formulário da purchase order line, foram adicionados 4 pages (
fiscal_taxes,fiscal_line_extra_info,otherseaccounting) ao notebook do formulário através do módulol10n_br_purchase, e é necessário controlar a visibilidade dessas pages para serem exibidas somente quando temos uma Operação Fiscal definida, porém os camposfiscal_taxesefiscal_line_extra_infosempre são sobrescritos pelo módulol10n_br_fiscal(document_fiscal_line_mixin_methods.py#L53) não permitindo adicionar o atributoinvisible. Para isso, através da PR #2759, foi criado um novo notebook ao final do formulário e a visibilidade é controlada nos atributos dos notebooks. Porém no módulo web, ao clicar no botão "Save & New" nos formulários, é feita uma validação do index ativo do notebook (web/static/src/js/views/form/form_renderer.js#L267), e é nessa validação que o erro reportado na issue é disparado.Foi identificado que isso está acontecendo pois a validação puxa o primeiro notebook no formulário, por conta disso, movemos o notebook com as pages adicionadas para antes do notebook original, e assim como o original (purchase/views/purchase_views.xml#L283), dentro da tag
<group colspan="12"></group>.cc: @marcelsavegnago @kaynnan @Matthwhy