Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to version 16.0 #149

Open
2 tasks done
sbidoul opened this issue Oct 3, 2022 · 4 comments
Open
2 tasks done

Migration to version 16.0 #149

sbidoul opened this issue Oct 3, 2022 · 4 comments
Labels
help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress
Milestone

Comments

@sbidoul
Copy link
Member

sbidoul commented Oct 3, 2022

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0

Modules to migrate

  • companyweb_base
  • companyweb_payment_info

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

@sbidoul sbidoul added help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress labels Oct 3, 2022
@sbidoul sbidoul added this to the 16.0 milestone Oct 3, 2022
@kmagusiak
Copy link

companyweb_base is already migrated to v16.
Seems like the dependency on web_notify is not mandatory, maybe it could stay this way and another module companyweb_notify could be created to install that optional dependency.

@sbidoul
Copy link
Member Author

sbidoul commented Feb 17, 2023

@kmagusiak not sure I understand your point. Both companyweb modules are now migrated to 16.0 and work fine without the web_notify module, which provided only a minor UX improvement.

@kmagusiak
Copy link

Very well. In the code I saw that web_notify was commented, so I though there were plans to bring it back.

@bjornbillen
Copy link

@sbidoul @kmagusiak , the web_notify module is now available for 16.0 in the web repo. So could you either update the code if you still want to use the "notify" functionality (which seems convenient for the end user, he get's notified that the customer details are succesfully fetched) or else the commented lines should be removed. Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress
Projects
None yet
Development

No branches or pull requests

3 participants