From c4518fd2ce32b76296cb189e438b84ceaecdc391 Mon Sep 17 00:00:00 2001
From: Justine Doutreloux <justine.doutreloux@gmail.com>
Date: Thu, 7 Nov 2024 17:14:58 +0100
Subject: [PATCH] [MIG] document_page: Migration to 18.0

---
 document_page/models/document_page.py         | 10 ++++-----
 document_page/models/document_page_history.py |  8 ++-----
 document_page/views/document_page.xml         | 21 ++++++++++---------
 .../views/document_page_category.xml          | 16 +++++++-------
 document_page/views/document_page_history.xml | 12 ++++++-----
 .../wizard/document_page_create_menu.py       |  2 +-
 .../wizard/document_page_show_diff.py         |  4 ++--
 7 files changed, 35 insertions(+), 38 deletions(-)

diff --git a/document_page/models/document_page.py b/document_page/models/document_page.py
index a1a7ca039c7..d5542feeee2 100644
--- a/document_page/models/document_page.py
+++ b/document_page/models/document_page.py
@@ -1,7 +1,7 @@
 # Copyright (C) 2004-2010 Tiny SPRL (<http://tiny.be>).
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 from odoo.exceptions import ValidationError
 
 
@@ -111,8 +111,8 @@ def _compute_backend_url(self):
 
     @api.constrains("parent_id")
     def _check_parent_id(self):
-        if not self._check_recursion():
-            raise ValidationError(_("You cannot create recursive categories."))
+        if self._has_cycle():
+            raise ValidationError(self.env._("You cannot create recursive categories."))
 
     def _get_page_index(self, link=True):
         """Return the index of a document."""
@@ -184,9 +184,9 @@ def unlink(self):
     def copy(self, default=None):
         default = dict(
             default or {},
-            name=_("%s (copy)") % self.name,
+            name=self.env._("%s (copy)") % self.name,
             content=self.content,
             draft_name="1.0",
-            draft_summary=_("summary"),
+            draft_summary=self.env._("summary"),
         )
         return super().copy(default=default)
diff --git a/document_page/models/document_page_history.py b/document_page/models/document_page_history.py
index 35ddb3922ff..b2bf80a6506 100644
--- a/document_page/models/document_page_history.py
+++ b/document_page/models/document_page_history.py
@@ -3,7 +3,7 @@
 
 import difflib
 
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 
 
 class DocumentPageHistory(models.Model):
@@ -55,7 +55,7 @@ def _get_diff(self, v1, v2):
         line1 = text1.splitlines(True)
         line2 = text2.splitlines(True)
         if line1 == line2:
-            return _("There are no changes in revisions.")
+            return self.env._("There are no changes in revisions.")
         else:
             diff = difflib.HtmlDiff()
             return diff.make_table(
@@ -66,10 +66,6 @@ def _get_diff(self, v1, v2):
                 context=True,
             )
 
-    # TODO: Replace for _compute_display_name
-    def name_get(self):
-        return [(rec.id, "%s #%i" % (rec.page_id.name, rec.id)) for rec in self]
-
     @api.depends("page_id")
     def _compute_display_name(self):
         for rec in self:
diff --git a/document_page/views/document_page.xml b/document_page/views/document_page.xml
index 94baf4ffc65..3d14a24a264 100644
--- a/document_page/views/document_page.xml
+++ b/document_page/views/document_page.xml
@@ -1,16 +1,16 @@
 <?xml version="1.0" ?>
 <odoo>
-    <!-- wiki tree view -->
+    <!-- wiki list view -->
     <record id="view_wiki_tree_children" model="ir.ui.view">
-        <field name="name">document.page.tree</field>
+        <field name="name">document.page.list</field>
         <field name="model">document.page</field>
         <field name="priority">100</field>
         <field name="arch" type="xml">
-            <tree>
+            <list>
                 <field name="name" />
                 <field name="content_uid" />
                 <field name="content_date" />
-            </tree>
+            </list>
         </field>
     </record>
     <!-- wiki list view  -->
@@ -18,14 +18,14 @@
         <field name="name">document.page.list</field>
         <field name="model">document.page</field>
         <field name="arch" type="xml">
-            <tree>
+            <list>
                 <field name="name" />
                 <field name="parent_id" />
                 <field name="company_id" groups="base.group_multi_company" />
                 <field name="create_uid" column_invisible="1" />
                 <field name="content_uid" />
                 <field name="content_date" />
-            </tree>
+            </list>
         </field>
     </record>
     <!-- wiki Form view  -->
@@ -94,13 +94,13 @@
                         </page>
                         <page name="history" string="History">
                             <field name="history_ids">
-                                <tree>
+                                <list>
                                     <field name="id" />
                                     <field name="create_date" />
                                     <field name="name" />
                                     <field name="summary" />
                                     <field name="create_uid" />
-                                </tree>
+                                </list>
                             </field>
                         </page>
                     </notebook>
@@ -178,10 +178,11 @@
     <!-- page action -->
     <record id="action_page" model="ir.actions.act_window">
         <field name="name">Pages</field>
+        <field name="path">document_pages</field>
         <field name="res_model">document.page</field>
         <field name="domain">[('type','=','content')]</field>
         <field name="context">{'default_type': 'content'}</field>
-        <field name="view_mode">tree,form</field>
+        <field name="view_mode">list,form</field>
         <field name="view_id" ref="view_wiki_tree" />
         <field name="search_view_id" ref="view_wiki_filter" />
         <field name="help" type="html">
@@ -192,7 +193,7 @@
     </record>
     <record id="action_page_view_tree" model="ir.actions.act_window.view">
         <field name="sequence" eval="0" />
-        <field name="view_mode">tree</field>
+        <field name="view_mode">list</field>
         <field name="view_id" ref="view_wiki_tree" />
         <field name="act_window_id" ref="action_page" />
     </record>
diff --git a/document_page/views/document_page_category.xml b/document_page/views/document_page_category.xml
index 0ea59d7c5f8..345a3865848 100644
--- a/document_page/views/document_page_category.xml
+++ b/document_page/views/document_page_category.xml
@@ -48,25 +48,22 @@
                         </page>
                     </notebook>
                 </sheet>
-                <div class="oe_chatter">
-                    <field name="message_follower_ids" widget="mail_followers" />
-                    <field name="message_ids" widget="mail_thread" />
-                </div>
+                <chatter />
             </form>
         </field>
     </record>
     <record id="view_category_tree" model="ir.ui.view">
-        <field name="name">document.page.category.tree</field>
+        <field name="name">document.page.category.list</field>
         <field name="model">document.page</field>
         <field name="arch" type="xml">
-            <tree>
+            <list>
                 <field name="name" />
                 <field name="parent_id" />
                 <field name="create_uid" column_invisible="1" />
                 <field name="write_uid" />
                 <field name="write_date" />
                 <field name="company_id" groups="base.group_multi_company" />
-            </tree>
+            </list>
         </field>
     </record>
     <record id="view_document_category_filter" model="ir.ui.view">
@@ -106,16 +103,17 @@
     <!-- Category Action -->
     <record id="action_category" model="ir.actions.act_window">
         <field name="name">Category</field>
+        <field name="path">document_page_categories</field>
         <field name="res_model">document.page</field>
         <field name="domain">[('type','=','category')]</field>
         <field name="context">{'default_type': 'category'}</field>
-        <field name="view_mode">tree,form</field>
+        <field name="view_mode">list,form</field>
         <field name="view_id" ref="view_category_tree" />
         <field name="search_view_id" ref="view_document_category_filter" />
     </record>
     <record id="action_category_view_tree" model="ir.actions.act_window.view">
         <field name="sequence" eval="0" />
-        <field name="view_mode">tree</field>
+        <field name="view_mode">list</field>
         <field name="view_id" ref="view_category_tree" />
         <field name="act_window_id" ref="action_category" />
     </record>
diff --git a/document_page/views/document_page_history.xml b/document_page/views/document_page_history.xml
index 12dc52f2f17..c8353acfa68 100644
--- a/document_page/views/document_page_history.xml
+++ b/document_page/views/document_page_history.xml
@@ -1,18 +1,18 @@
 <?xml version="1.0" ?>
 <odoo>
-    <!-- History Tree view -->
+    <!-- History List view -->
     <record model="ir.ui.view" id="view_wiki_history_tree">
-        <field name="name">document.page.history.tree</field>
+        <field name="name">document.page.history.list</field>
         <field name="model">document.page.history</field>
         <field name="arch" type="xml">
-            <tree>
+            <list>
                 <field name="id" />
                 <field name="page_id" />
                 <field name="name" />
                 <field name="summary" />
                 <field name="create_uid" />
                 <field name="create_date" />
-            </tree>
+            </list>
         </field>
     </record>
 
@@ -81,8 +81,9 @@
     <!-- History Action  -->
     <record model="ir.actions.act_window" id="action_history">
         <field name="name">Page history</field>
+        <field name="path">document_page_history_all</field>
         <field name="res_model">document.page.history</field>
-        <field name="view_mode">tree,form</field>
+        <field name="view_mode">list,form</field>
     </record>
 
     <menuitem
@@ -96,6 +97,7 @@
 
     <record id="action_related_page_history" model="ir.actions.act_window">
         <field name="name">Page History</field>
+        <field name="path">document_page_history</field>
         <field name="res_model">document.page.history</field>
         <field name="domain">[('page_id','=',active_id)]</field>
         <field
diff --git a/document_page/wizard/document_page_create_menu.py b/document_page/wizard/document_page_create_menu.py
index cf7bfb17e00..d03d246916d 100644
--- a/document_page/wizard/document_page_create_menu.py
+++ b/document_page/wizard/document_page_create_menu.py
@@ -36,7 +36,7 @@ def document_page_menu_create(self):
         view_id = obj_model_data._xmlid_to_res_id("document_page.view_wiki_menu_form")
         value = {
             "name": "Document Page",
-            "view_mode": "form,tree",
+            "view_mode": "form,list",
             "res_model": "document.page",
             "view_id": view_id,
             "type": "ir.actions.act_window",
diff --git a/document_page/wizard/document_page_show_diff.py b/document_page/wizard/document_page_show_diff.py
index 1557ff7b8d3..e7bce5a00bb 100644
--- a/document_page/wizard/document_page_show_diff.py
+++ b/document_page/wizard/document_page_show_diff.py
@@ -1,7 +1,7 @@
 # Copyright (C) 2004-2010 Tiny SPRL (<http://tiny.be>).
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
-from odoo import _, fields, models
+from odoo import fields, models
 from odoo.exceptions import UserError
 
 
@@ -24,7 +24,7 @@ def _get_diff(self):
         elif len(ids) == 1:
             diff = history.browse(ids[0]).diff
         else:
-            raise UserError(_("Select one or maximum two history revisions!"))
+            raise UserError(self.env._("Select one or maximum two history revisions!"))
         return diff
 
     diff = fields.Html(readonly=True, default=_get_diff)