Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] crm_phonecall: Migration to 17.0 #540

Merged
merged 79 commits into from
Jul 11, 2024

Conversation

peluko00
Copy link

@peluko00 peluko00 commented Dec 1, 2023

Module migrated to version 17.0

cc https://github.com/APSL 149031

@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review

Issue #525

cubells and others added 30 commits December 1, 2023 08:39
* crm_phonecall module (OCA#131)

This module is the part extracted from Odoo v8 crm module from Odoo that allows to record phone calls. As it has been stripped off from Odoo v9, we add again the feature via this module.

Migration scripts are also included to upgrade a v8 database via OpenUpgrade and don't lose your history.

* [MIG] crm_phone_call: Migrated to 10.0

 - FIX: Correct some lint errors

* [MIG] crm_phone_call: Migrated to 10.0
Currently translated at 100.0% (150 of 150 strings)

Translation: crm-12.0/crm-12.0-crm_phonecall
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/es/
Currently translated at 86.0% (129 of 150 strings)

Translation: crm-12.0/crm-12.0-crm_phonecall
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/
Currently translated at 92.7% (139 of 150 strings)

Translation: crm-12.0/crm-12.0-crm_phonecall
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/
Currently translated at 98.0% (147 of 150 strings)

Translation: crm-12.0/crm-12.0-crm_phonecall
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/
Currently translated at 27.3% (41 of 150 strings)

Translation: crm-12.0/crm-12.0-crm_phonecall
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/hr/
Currently translated at 41.3% (62 of 150 strings)

Translation: crm-12.0/crm-12.0-crm_phonecall
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/hr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: crm-13.0/crm-13.0-crm_phonecall
Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_phonecall/
Copy link
Member

@lbarry-apsl lbarry-apsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, tested on Runboat

@lbarry-apsl
Copy link
Member

I was hoping to see the categories in the logged calls, it could be an improvement.

@peluko00 peluko00 force-pushed the 17.0-mig-crm_phonecall branch 3 times, most recently from b55602d to b0c084f Compare May 15, 2024 12:36
@carolinafernandez-tecnativa
Copy link
Contributor

Hi could you please rebase and squash administrative commits? Thanks!

mymage and others added 13 commits July 8, 2024 09:03
Currently translated at 100.0% (161 of 161 strings)

Translation: crm-16.0/crm-16.0-crm_phonecall
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/it/
Currently translated at 100.0% (161 of 161 strings)

Translation: crm-16.0/crm-16.0-crm_phonecall
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: crm-16.0/crm-16.0-crm_phonecall
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/
Currently translated at 100.0% (155 of 155 strings)

Translation: crm-16.0/crm-16.0-crm_phonecall
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/it/
Currently translated at 100.0% (155 of 155 strings)

Translation: crm-16.0/crm-16.0-crm_phonecall
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: crm-16.0/crm-16.0-crm_phonecall
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/
Currently translated at 100.0% (154 of 154 strings)

Translation: crm-16.0/crm-16.0-crm_phonecall
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/es_AR/
Currently translated at 100.0% (154 of 154 strings)

Translation: crm-16.0/crm-16.0-crm_phonecall
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_phonecall/it/
@peluko00 peluko00 force-pushed the 17.0-mig-crm_phonecall branch from b0c084f to 0a15e47 Compare July 8, 2024 07:04
@peluko00
Copy link
Author

peluko00 commented Jul 8, 2024

Hi could you please rebase and squash administrative commits? Thanks!

Done! Ready for review

@CRogos
Copy link

CRogos commented Jul 8, 2024

There are still a lot of commits which should be squashed. Here some examples, but there are a lot more:

image
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although technically not all the administrative are squashed, let's move with this as this is blocking other migrations and we can continue the squashing on the next migration.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-540-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 851058a into OCA:17.0 Jul 11, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0f2e729. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.