From b0c084f8fea52f1482172d9895c83cbe4ba6dd77 Mon Sep 17 00:00:00 2001
From: Antoni Marroig Campomar <amarroig@apsl.net>
Date: Fri, 1 Dec 2023 08:42:10 +0100
Subject: [PATCH] [MIG] crm_phonecall: Migration to 17.0

---
 crm_phonecall/README.rst                      |  3 ++
 crm_phonecall/__manifest__.py                 |  2 +-
 crm_phonecall/models/crm_phonecall.py         |  6 ++--
 crm_phonecall/readme/CONTRIBUTORS.md          |  2 ++
 crm_phonecall/static/description/index.html   |  4 +++
 crm_phonecall/views/crm_phonecall_view.xml    | 26 +++++++--------
 .../views/res_config_settings_views.xml       | 32 ++++++-------------
 .../crm_phonecall_to_phonecall_view.xml       |  8 ++---
 8 files changed, 39 insertions(+), 44 deletions(-)

diff --git a/crm_phonecall/README.rst b/crm_phonecall/README.rst
index f2b35e2c8f9..0d0513c51e1 100644
--- a/crm_phonecall/README.rst
+++ b/crm_phonecall/README.rst
@@ -94,6 +94,9 @@ Contributors
    -  Manuel Marquez <manuel.marquez@druidoo.io>
 
 -  Ruchir Shukla <ruchir@bizzappdev.com>
+-  `APSL-Nagarro <https://apsl.tech>`__:
+
+   -  Antoni Marroig <amarroig@apsl.net>
 
 Maintainers
 -----------
diff --git a/crm_phonecall/__manifest__.py b/crm_phonecall/__manifest__.py
index 84368e0328f..630859412e1 100644
--- a/crm_phonecall/__manifest__.py
+++ b/crm_phonecall/__manifest__.py
@@ -3,7 +3,7 @@
 
 {
     "name": "CRM Phone Calls",
-    "version": "16.0.1.1.0",
+    "version": "17.0.1.0.0",
     "category": "Customer Relationship Management",
     "author": "Odoo S.A., Tecnativa, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/crm",
diff --git a/crm_phonecall/models/crm_phonecall.py b/crm_phonecall/models/crm_phonecall.py
index 5a703509ebf..946c292acbf 100644
--- a/crm_phonecall/models/crm_phonecall.py
+++ b/crm_phonecall/models/crm_phonecall.py
@@ -219,8 +219,10 @@ def action_button_convert2opportunity(self):
         return opportunity_id.redirect_lead_opportunity_view()
 
     def _get_view(self, view_id=None, view_type="form", **options):
-        """Inject group check to make the tree editable or not. Apparently it can't be done
-        by pure view inheritance and attribute overriding"""
+        """
+        Inject group check to make the tree editable or not. Apparently it can't be done
+        by pure view inheritance and attribute overriding
+        """
         arch, view = super()._get_view(view_id, view_type, **options)
         if view_type == "tree" and self.env.user.has_group(
             "crm_phonecall.group_show_form_view"
diff --git a/crm_phonecall/readme/CONTRIBUTORS.md b/crm_phonecall/readme/CONTRIBUTORS.md
index 3005608af93..a3b5032b7eb 100644
--- a/crm_phonecall/readme/CONTRIBUTORS.md
+++ b/crm_phonecall/readme/CONTRIBUTORS.md
@@ -11,3 +11,5 @@
   - Iván Todorovich \<<ivan.todorovich@druidoo.io>\>
   - Manuel Marquez \<<manuel.marquez@druidoo.io>\>
 - Ruchir Shukla \<<ruchir@bizzappdev.com>\>
+- [APSL-Nagarro](https://apsl.tech):
+  - Antoni Marroig  \<<amarroig@apsl.net>\>
diff --git a/crm_phonecall/static/description/index.html b/crm_phonecall/static/description/index.html
index e5d811a853f..9472bc0bc43 100755
--- a/crm_phonecall/static/description/index.html
+++ b/crm_phonecall/static/description/index.html
@@ -443,6 +443,10 @@ <h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
 </ul>
 </li>
 <li>Ruchir Shukla &lt;<a class="reference external" href="mailto:ruchir&#64;bizzappdev.com">ruchir&#64;bizzappdev.com</a>&gt;</li>
+<li><a class="reference external" href="https://apsl.tech">APSL-Nagarro</a>:<ul>
+<li>Antoni Marroig &lt;<a class="reference external" href="mailto:amarroig&#64;apsl.net">amarroig&#64;apsl.net</a>&gt;</li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
diff --git a/crm_phonecall/views/crm_phonecall_view.xml b/crm_phonecall/views/crm_phonecall_view.xml
index 859dafa124c..027b12d2e48 100644
--- a/crm_phonecall/views/crm_phonecall_view.xml
+++ b/crm_phonecall/views/crm_phonecall_view.xml
@@ -41,23 +41,22 @@
                 <button
                     icon="fa-calendar"
                     name="action_make_meeting"
-                    states="open,pending"
+                    invisible="state not in ['open', 'pending']"
                     string="Meeting"
                     type="object"
                 />
                 <button
-                    attrs="{'invisible':[('opportunity_id','!=',False)]}"
+                    invisible="opportunity_id or state not in ['open', 'pending']"
                     icon="fa-hand-pointer-o"
                     name="action_button_convert2opportunity"
-                    states="open,pending"
                     string="Convert to Opportunity"
                     type="object"
                 />
                 <field name="partner_phone" />
                 <field name="user_id" />
-                <field invisible="1" name="tag_ids" />
-                <field invisible="1" name="create_date" />
-                <field invisible="1" name="opportunity_id" />
+                <field column_invisible="1" name="tag_ids" />
+                <field column_invisible="1" name="create_date" />
+                <field column_invisible="1" name="opportunity_id" />
                 <field name="state" />
             </tree>
         </field>
@@ -78,7 +77,7 @@
                 <sheet string="Phone Call">
                     <div class="oe_button_box" name="button_box">
                         <button
-                            attrs="{'invisible':[ '|', ('opportunity_id','!=',False), ('state', 'not in', ('open', 'done'))]}"
+                            invisible="opportunity_id or state not in ['open', 'done']"
                             class="oe_stat_button"
                             help="Convert To Opportunity"
                             icon="fa-star"
@@ -194,17 +193,17 @@
                 <field name="date" />
                 <field name="name" />
                 <field name="partner_id" />
-                <field invisible="1" name="partner_phone" />
-                <field invisible="1" name="partner_mobile" />
+                <field column_invisible="1" name="partner_phone" />
+                <field column_invisible="1" name="partner_mobile" />
                 <field
                     context="{'default_groups_ref': ['base.group_user', 'base.group_partner_manager', 'sales_team.group_sale_salesman']}"
                     name="user_id"
                 />
-                <field invisible="1" name="tag_ids" widget="many2many_tags" />
+                <field column_invisible="1" name="tag_ids" widget="many2many_tags" />
                 <field name="direction" />
                 <field name="state" />
-                <field invisible="1" name="create_date" />
-                <field invisible="1" name="opportunity_id" />
+                <field column_invisible="1" name="create_date" />
+                <field column_invisible="1" name="opportunity_id" />
                 <field groups="base.group_no_one" name="campaign_id" />
                 <field groups="base.group_no_one" name="source_id" />
                 <field groups="base.group_no_one" name="medium_id" />
@@ -221,10 +220,9 @@
                     type="object"
                 />
                 <button
-                    attrs="{'invisible':[('opportunity_id','!=',False)]}"
+                    invisible="opportunity_id or state != 'open' or state != 'pending'"
                     icon="fa-hand-pointer-o"
                     name="action_button_convert2opportunity"
-                    states="open,pending"
                     string="Convert to Opportunity"
                     type="object"
                 />
diff --git a/crm_phonecall/views/res_config_settings_views.xml b/crm_phonecall/views/res_config_settings_views.xml
index 46f4305dbbe..a508f035a0d 100644
--- a/crm_phonecall/views/res_config_settings_views.xml
+++ b/crm_phonecall/views/res_config_settings_views.xml
@@ -5,29 +5,15 @@
         <field name="model">res.config.settings</field>
         <field name="inherit_id" ref="crm.res_config_settings_view_form" />
         <field name="arch" type="xml">
-            <div data-string="CRM" position="inside">
-                <h2>Phonecalls</h2>
-                <div class="row mt16 o_settings_container">
-                    <div class="col-lg-6 o_setting_box">
-                        <div class="o_setting_left_pane">
-                            <field name="group_show_form_view" />
-                        </div>
-                        <div
-                            class="o_setting_right_pane"
-                            id="crm_phonecall_show_form_settings"
-                        >
-                            <label
-                                for="group_show_form_view"
-                                string="Enable form view for phone calls"
-                            />
-                            <div class="text-muted">
-                                By default form view is disabled for calls, with this
-                                setting it is enabled for all users.
-                            </div>
-                        </div>
-                    </div>
-                </div>
-            </div>
+            <xpath expr="//app[@name='crm']" position="inside">
+                <block title="Phonecalls" name="o_settings_container">
+                    <setting
+                        help="By default form view is disabled for calls, with this setting it is enabled for all users."
+                    >
+                        <field name="group_show_form_view" />
+                    </setting>
+                </block>
+            </xpath>
         </field>
     </record>
 </odoo>
diff --git a/crm_phonecall/wizard/crm_phonecall_to_phonecall_view.xml b/crm_phonecall/wizard/crm_phonecall_to_phonecall_view.xml
index 0c436e8dc95..13cec710b68 100644
--- a/crm_phonecall/wizard/crm_phonecall_to_phonecall_view.xml
+++ b/crm_phonecall/wizard/crm_phonecall_to_phonecall_view.xml
@@ -8,13 +8,13 @@
                 <group>
                     <group>
                         <field name="action" />
-                        <field attrs="{'readonly': [(1,'=',1)]}" name="partner_id" />
+                        <field readonly="1" name="partner_id" />
                         <field groups="sales_team.group_sale_salesman" name="team_id" />
                     </group>
                     <group>
                         <field name="name" />
                         <field
-                            attrs="{'invisible': [('action','=','log')]}"
+                            invisible="action == 'log'"
                             name="date"
                             string="Planned Date"
                         />
@@ -27,14 +27,14 @@
                 </group>
                 <footer>
                     <button
-                        attrs="{'invisible' : [('action', '!=', 'log')]}"
+                        invisible="action != 'log'"
                         class="oe_highlight"
                         name="action_schedule"
                         string="Log Call"
                         type="object"
                     />
                     <button
-                        attrs="{'invisible' : [('action', '!=', 'schedule')]}"
+                        invisible="action != 'schedule'"
                         class="oe_highlight"
                         name="action_schedule"
                         string="Schedule Call"