[16.0] account_mass_reconcile no view of reconciled display items

[syera94]

Account_mass_reconcile

In the module it's not possible to see which items was reconciled from the history page or from the tree view "display items reconciles on the last run"

Describe the bug

it seems to be not possible to check all the reconciled move line from the history page of the module or from the tree view.
line 206 of the mass_reconcile.py file , the field "full_reconcile_id", is empty. Consequently, all the line just reconciled by the module does not appear in the history view.

It sems the error com from the line 191 and 192 of the same python file : a new env is generated to store the concerned move_line. And this new env which has change is not call anymore.
Consequenlty, when we dont change the field reconciliation_commit_every from 1 to 0 the method find_reconcile_ids call the wrong env to find the reconciled move_lines.

To Reproduce

1.Go to accounting --> customer --> payment --> choose a partner and do a payment with reference
2.Go to accounting --> customer --> invoice --> do a invoice whit the same partner and the same amount and reference
3.Got to accounting --> mass automatic reconcile --> create a new one and choose simple amount and partner
4.Check the number of unreconciled move line --> click the button start auto reconciliation
5.Check the number of unreconciled move line (which is less) --> and go to "display items on the last run"
Nothing appears

Expected behavior
The reconcile move line should appear when we click on the button "display items on the last run"

temporary solution which work for my customer

As my customer doesnt habe too many reconciled line per auto reconciliation, I change in data base the field reconciliation_commit_every from 1 to 0 to avoid commit in the midlle of the treatement.
And this way, the code new_env is the same than the regular and find the line in this env.

[github-actions]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

[sergiobstoj]

I have opened a PR that resolves this issue. #686