[18.0][MIG] account_invoice_refund_link: Migration to 18.0 #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhancements: * Reverse link from invoice to refunds also available. * Link at invoice line level, not only at invoice level. * When installing the module after some refunds have been made, the module tries to find the link to the original invoice for them. * OCA Guidelines compliance. * Compatibility in OpenUpgrade for migrating from 8.0 module account_refund_original. * Tests with 100% coverage. Technical changes: * Rename field origin_invoices_ids to origin_invoice_ids * Rename field refund_invoices_description to refund_reason * Rename addon to account_invoice_refund_link
Odoo already includes a method for preparing the refund, so using it we don't have to make any guess about the returned domain and the method also serves for refunds created directly by code. Initial line match has also been improved comparing product or description.
* [FIX] account_invoice_refund_link: Don't copy m2m fields Many2many fields have copy=True property by default, having an incorrect duplication of origin or refund invoices. Steps to reproduce: * Create an invoice * Refund it * Duplicate the original invoice * The refund will be link to 2 original invoices Included tests covering the use cases for avoiding future regressions.
Since v11, Odoo counts with a field called `refund_invoice_ids` of type one2many, which conflicts with the m2m field defined in this module. Moreover, these fields are not needed anymore. There is only 2 OCA modules using this module right now, and they don't need significant changes for this adaptation, but I will do it when this get merged.
Currently translated at 100.0% (17 of 17 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_refund_link/de/
Currently translated at 100.0% (17 of 17 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_refund_link/pt_BR/
Currently translated at 100.0% (11 of 11 strings) Translation: account-invoicing-13.0/account-invoicing-13.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_invoice_refund_link/pt_BR/
…edit note invoice has done from sale order.
Currently translated at 100.0% (12 of 12 strings) Translation: account-invoicing-13.0/account-invoicing-13.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_invoice_refund_link/pt_BR/
Currently translated at 100.0% (12 of 12 strings) Translation: account-invoicing-14.0/account-invoicing-14.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_invoice_refund_link/es/
Currently translated at 83.3% (10 of 12 strings) Translation: account-invoicing-14.0/account-invoicing-14.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_invoice_refund_link/fr/
Currently translated at 100.0% (12 of 12 strings) Translation: account-invoicing-14.0/account-invoicing-14.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_invoice_refund_link/es_AR/
Currently translated at 91.6% (11 of 12 strings) Translation: account-invoicing-14.0/account-invoicing-14.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_invoice_refund_link/fr_FR/
Currently translated at 100.0% (12 of 12 strings) Translation: account-invoicing-14.0/account-invoicing-14.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_invoice_refund_link/pt_PT/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-17.0/account-invoicing-17.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-17-0/account-invoicing-17-0-account_invoice_refund_link/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-17.0/account-invoicing-17.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-17-0/account-invoicing-17-0-account_invoice_refund_link/
Currently translated at 100.0% (12 of 12 strings) Translation: account-invoicing-17.0/account-invoicing-17.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-17-0/account-invoicing-17-0-account_invoice_refund_link/sv/
Currently translated at 100.0% (12 of 12 strings) Translation: account-invoicing-17.0/account-invoicing-17.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-17-0/account-invoicing-17-0-account_invoice_refund_link/it/
Currently translated at 100.0% (12 of 12 strings) Translation: account-invoicing-17.0/account-invoicing-17.0-account_invoice_refund_link Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-17-0/account-invoicing-17-0-account_invoice_refund_link/pt/
|
/ocabot migration account_invoice_refund_link |
|
This PR has the |
pedrobaeza
reviewed
Nov 26, 2024
| @@ -90,6 +90,10 @@ Contributors | |||
|
|
|||
| - Luis J. Salvatierra <[email protected]> | |||
|
|
|||
| - `Factor Libre <https://factorlibre.com>`__: | |||
|
|
|||
| - Luis J. Salvatierra <[email protected]> | |||
There was a problem hiding this comment.
This contributor is being added at 18.0 migration commit, which doesn't sound correct.
peluko00
force-pushed
the
18.0-mig-account_invoice_refund_link
branch
from
803fe04
to
2247877
Compare
peluko00
force-pushed
the
18.0-mig-account_invoice_refund_link
branch
from
2247877
to
e28fc73
Compare
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 94bda72. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module migrated to version 18.0
cc https://github.com/APSL 163709
@miquelalzanillas @javierobcn @mpascuall @BernatObrador @ppyczko please review