Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_invoice_show_currency_rate: Migration to 16.0 #1522

Merged
merged 10 commits into from
Aug 13, 2023
Merged

[16.0][MIG] account_invoice_show_currency_rate: Migration to 16.0 #1522

merged 10 commits into from
Aug 13, 2023

Conversation

ACheung-FactorLibre
Copy link

No description provided.

@ACheung-FactorLibre ACheung-FactorLibre mentioned this pull request Aug 3, 2023
Open
64 tasks
@ACheung-FactorLibre
Copy link
Author

#1250

@ACheung-FactorLibre ACheung-FactorLibre force-pushed the 16.0-mig-account_invoice_show_currency_rate branch from ee2f4ae to cfa2ed4 Compare August 4, 2023 08:22
Gelo-fl
Gelo-fl approved these changes Aug 8, 2023
View reviewed changes
Copy link

@Gelo-fl Gelo-fl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM https://www.awesomescreenshot.com/video/19763045?key=586365e80754c88cfa8fe661a43ef574

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rafaelbn
Copy link
Member

/ocabot migration account_invoice_show_currency_rate

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Aug 12, 2023
rafaelbn
rafaelbn approved these changes Aug 12, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this migration! 👍🏼

@Gelo-fl nice awesome review! 😄

@rafaelbn
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1522-by-rafaelbn-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 12, 2023
@OCA-git-bot
Merge PR #1522 into 16.0
1036094 
Signed-off-by rafaelbn
@rafaelbn rafaelbn changed the title [WIP][16.0][MIG] account_invoice_show_currency_rate: Migration to 16.0 [16.0][MIG] account_invoice_show_currency_rate: Migration to 16.0 Aug 12, 2023
@rafaelbn
Copy link
Member

/ocabot migration account_invoice_show_currency_rate

@OCA-git-bot
Copy link
Contributor

@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1522-by-rafaelbn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@rafaelbn
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1522-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6acdc22 into OCA:16.0 Aug 13, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ffa13a6. Thanks a lot for contributing to OCA. ❤️

@RodrigoBM RodrigoBM deleted the 16.0-mig-account_invoice_show_currency_rate branch August 30, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gelo-fl Gelo-fl Gelo-fl approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

@RodrigoBM RodrigoBM RodrigoBM approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ACheung-FactorLibre @OCA-git-bot @rafaelbn @RodrigoBM @Gelo-fl @victoralmau @oca-travis