[15.0][FIX] account_move_update_analytic: Switch button text to icon #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shide
changed the title
Shide
force-pushed
the
15.0-replace_text_with_icon-account_move_update_analytic
branch
from
38aa98b to
86f591c
Compare
|
LGTM |
EmilioPascual
approved these changes
Sep 21, 2023
yajo
approved these changes
Sep 21, 2023
remi-filament
approved these changes
Sep 25, 2023
I do not think this module is necessary in v16.0 since you can already update analytic distribution ! |
|
This PR has the |
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 1f43914. Thanks a lot for contributing to OCA. ❤️ |
yajo
deleted the
15.0-replace_text_with_icon-account_move_update_analytic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Button text is super large and doesn't fit well on any screen. Also is pretty ugly
Replace the button text with a pretty icon
fa-tagsand add a proper title to know what is going to happen if you click the button.Also added maintainers
I pretend to FWP this commit into 16.0 once it's merged.
MT-3838 @moduon @yajo @rafaelbn @EmilioPascual @remi-filament plz review if you want 😄