Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate log subscription specificities #228

Open
Hyodar opened this issue Jun 5, 2024 · 0 comments
Open

Investigate log subscription specificities #228

Hyodar opened this issue Jun 5, 2024 · 0 comments

Comments

@Hyodar
Copy link
Contributor

Hyodar commented Jun 5, 2024

Log subscription seems to be a quite problematic use-case - it's not common, so the support is scarce and we can encounter bugs. There are also some factors such as specific client implementations affecting the expected behavior, such as what seems to be filter timeouts for Geth: https://github.com/ethereum/go-ethereum/blob/bc6569462dfd78394599c93fd9e2a21908aca662/eth/filters/filter_system.go#L47 and the bug we found on unsubscribes in some providers.

We should investigate these details and adapt the SafeEthClient implementation to better handle them.

Keeping this issue for discussion and linking related PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant