Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popTo from useNavigation is missing componentId parameter #58

Open
ghost opened this issue Feb 23, 2021 · 4 comments
Open

popTo from useNavigation is missing componentId parameter #58

ghost opened this issue Feb 23, 2021 · 4 comments
Assignees

Comments

@ghost
Copy link

ghost commented Feb 23, 2021

Hello,

I am trying to replace Navigation.popTo(componentId) with useNavigation hook, however according to typings there is not support for passing componentId which I want to pop to.

const {popTo} = useNavigation();
popTo(someComponentId); // <-- can not pass componentId

Please compare official rnn docs with rnn hooks docs to see the difference.

If this is not a mistake then please instruct me how to implement requested scenario. Btw I am glad to have this library, the code is so clean. Thank you.

@jpgarcia
Copy link
Collaborator

You're right! good catch.
This is a breaking change but since nobody has mentioned it before I think it won't have much impact
I'll let you know as soon as I can publish the new version

Thank you for reporting this!

@jpgarcia jpgarcia self-assigned this Feb 25, 2021
@mtzfactory
Copy link

mtzfactory commented Jun 15, 2021

Hi, I'm interested in this change as well ;-)

@keremoge
Copy link

keremoge commented Aug 3, 2021

Any update?

@kvntzn
Copy link

kvntzn commented Sep 7, 2022

glad to have this one on the next release

jpgarcia added a commit that referenced this issue Nov 7, 2022
- Extract helpers commands from createNavigationCommand tests
- Add missing parameter to the popTo function
- Deprecate popTo helper

fix #58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants