Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The worker checking mechanism is missing. #3

Open
pawnz0 opened this issue Sep 20, 2022 · 0 comments
Open

The worker checking mechanism is missing. #3

pawnz0 opened this issue Sep 20, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@pawnz0
Copy link
Member

pawnz0 commented Sep 20, 2022

Describe the Bug
In current version, when bonding a worker node, it will only check if the node uri is online, and the current node uri has been used or not. But if the node uri is online and not been used before, it can be used for bonding neglect the real status of the worker nodes.

To Reproduce
If you can ping a false node with xxx:9151 URI, and use it to bond any fresh worker account to a fresh staker account. You will succeed. But this nodes is not runing at all.

Suggestion to fix it
Add a checking mechanism: when the backend server ping the node, the node need to return a signature which is signed by the worker account, the message is the node uri. Then when server check the signature, it can check if this worker is running with specific URI. This is one suggestion, maybe we can discuss it with other possibility to fix it.

@pawnz0 pawnz0 added the bug Something isn't working label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants