You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So, I see pros and cons for both, may be we can keep them.
If we keep only the one inside connector, it means all connectors object will have to inherit from connector. If you forget, then extra class doesn't work. in the other hand, keep it inside create_backend will always allow users to add extra_class inside the yaml file.
The text was updated successfully, but these errors were encountered:
Looks like inside create_backend, the code to add class is not anymore needed because of super class ?
Here the code if (!is.null(backend$extra_class)) {
now, the connector R6 also give the opportunity to add the extra class, see here :
connector/R/connector.R
Line 51 in 7c2c7cc
So, I see pros and cons for both, may be we can keep them.
If we keep only the one inside connector, it means all connectors object will have to inherit from connector. If you forget, then extra class doesn't work. in the other hand, keep it inside create_backend will always allow users to add extra_class inside the yaml file.
The text was updated successfully, but these errors were encountered: