fix: update cnt_download and cnt_upload to the same behaviour

[Cervangirard]

download_cnt returns the file :

connector/R/fs_methods.R

Line 134 in 7c2c7cc

return(invisible(file))

upload_cnt returns the connector object

connector/R/fs_methods.R

Line 166 in 7c2c7cc

return(invisible(connector_object))

I don't if they should return the file or the object, but we should be consistent.

May be the object is a best idea to be able to use the pipe

[vladimirobucina]

@Cervangirard Downloading file should return the file and it is the final result of that method, because that file can later be used in further analysis (piping it to load it or use it in any other way).

Here it is more of a question for upload_cnt what it should return. Honestly, how it is now, it makes sense to me, because depending on which fs type we're using return value might be different from case to case. Ideally we would get file_id of some sorts, which we could later use to reference that file and manipulate it in some way.

What do you think @akselthomsen?

[akselthomsen]

Agree on download_cnt.

For upload_cnt I like returning the connector_object. Mostly because once uploaded I would not expect the same script to reference it again afterwards. Think it would also be hard to have a common way to refer to the uploaded file.