Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue Project reviews after Complete #594

Open
dbludeau opened this issue Sep 24, 2024 · 3 comments
Open

Continue Project reviews after Complete #594

dbludeau opened this issue Sep 24, 2024 · 3 comments
Assignees

Comments

@dbludeau
Copy link
Contributor

Super minor change request (not vital at all)
When you mark a project as "Complete" and then archive it, it would be create if it automatically went to the next project to review (like it does when you hit "Finish + Next".
Currently it stops the review process.

@jgclark jgclark changed the title Projects and Reviews Continue Project reviews after Complete Sep 24, 2024
@jgclark jgclark self-assigned this Sep 24, 2024
@jgclark
Copy link
Collaborator

jgclark commented Sep 24, 2024

@dbludeau this is more tricky than it seems.
The challenge is that there's no state keeping track of whether you're currently reviewing projects or not. (Or indeed a way of deciding you've stopped.) At the moment there are two actions: "finish" and "finish + next". The latter tells the plugin to move on. I didn't want to duplicate the "start" and "complete" actions in the same way, as there would be getting on for too many actions and their buttons.

So, if there's a neat way of indicating this in the intention, then please do suggest it.
But it needs to cope with just calling complete on an project without being part of a review sequence.

@dbludeau
Copy link
Contributor Author

@jgclark Thanks for the background. This is really only saving a click or two, so not worth adding more complexity for that little benefit. Thanks for the great plugin!

@jgclark
Copy link
Collaborator

jgclark commented Sep 26, 2024

I don't mind more complexity in the code, but I don't want to increase complexity for users to pick it up, without good reason ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants