Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspector UI modification #255

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Inspector UI modification #255

wants to merge 5 commits into from

Conversation

Benjtalkshow
Copy link

Detailed Information

Related Issues

Closes #248

Type of Change

  • 🐛 Bug fix or ⚙️ enhancement
  • ✨ New feature or Chore (change with no new features or fixes)
  • 📚 Documentation update

Checklist (select as many as applicable)

  • The code follows the style guidelines of this project.
  • All new and existing tests pass.
  • This pull request is ready to be merged and reviewed.

@Benjtalkshow Benjtalkshow marked this pull request as ready for review December 20, 2024 20:54
Solomonsolomonsolomon
Solomonsolomonsolomon requested changes Dec 22, 2024
View reviewed changes
Copy link
Contributor

@Solomonsolomonsolomon Solomonsolomonsolomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, however its dummy data.. replace with live data .hint: use reusable components for ease

@Benjtalkshow
Copy link
Author

looks good, however its dummy data.. replace with live data .hint: use reusable components for ease

Alright

@Benjtalkshow
Copy link
Author

@Solomonsolomonsolomon

I left a message in your TG account.

@Solomonsolomonsolomon
Copy link
Contributor

kindly reconfirm the recipient as i didnt receive any message

@Benjtalkshow
Copy link
Author

kindly reconfirm the recipient as i didnt receive any message

Hello @Solomonsolomonsolomon
Please check your DM. On telegram.

@Benjtalkshow
Copy link
Author

@Solomonsolomonsolomon
I have updated my PR.

Solomonsolomonsolomon
Solomonsolomonsolomon reviewed Dec 28, 2024
View reviewed changes
Copy link
Contributor

@Solomonsolomonsolomon Solomonsolomonsolomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not all pages work,some break and crash app

@Benjtalkshow
Copy link
Author

not all pages work,some break and crash app

@Solomonsolomonsolomon
Can you list the pages that crashes the app? Because I modified only two page where TableHeader and TableRow custom components were referenced.

@Solomonsolomonsolomon
Copy link
Contributor

You modified more than two files, check the files changed tab to see the files you modified
this page
app/client/src/views/inspector/Lands.tsx
throws the error
Screenshot 2024-12-28 at 19 22 43

@Benjtalkshow
Copy link
Author

Hello @Solomonsolomonsolomon
What's the update about this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Solomonsolomonsolomon Solomonsolomonsolomon Solomonsolomonsolomon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inspector Dashboard UI modifications
2 participants
@Benjtalkshow @Solomonsolomonsolomon