Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Margay_TimeSet to be fully OSX compatible #1

Open
5 tasks
bschulz1701 opened this issue May 16, 2019 · 0 comments
Open
5 tasks

Fix Margay_TimeSet to be fully OSX compatible #1

bschulz1701 opened this issue May 16, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@bschulz1701
Copy link
Contributor

Issue:

Code does not trigger into OSX condition (Len > 17) because it always trips at Ubuntu condition Len > 11, also substring usage is incorrect withing these functions. Needs to be substring(0, x) not simply, substring(x)

Solution:

Clarify OSX conditional, change sub-strings, test for use of cu vs tty port for OSX

  • Fix conditional
  • Fix substrings
  • Clarify cu vs. tty
  • Test on OSX
  • Test on Ubuntu
@bschulz1701 bschulz1701 added the bug Something isn't working label May 16, 2019
@bschulz1701 bschulz1701 self-assigned this May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant