Combine long press and two button reset #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the separate toggle for two button reset. This functionality Will be incorporated into the long press configuration instead. Signed-off-by: Andy Sinclair <[email protected]>
Changed long press toggle to dropdown. Now incorporates two button setting to reduce confusion. Signed-off-by: Andy Sinclair <[email protected]>
long-press-reset and ship-to-active-time added to overlay. Commented out as not available until NCS 2.7. Signed-off-by: Andy Sinclair <[email protected]>
Updated firmware to 1.1.1+0. Includes long press config changes and associated shell command. Signed-off-by: Andy Sinclair <[email protected]>
greg-fer
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
This needs a changelog entry, most likely, but I leave it to you @kylebonnici , @aasinclair to sync about adding it, as I don't want to mess the processes.
kylebonnici
reviewed
Mar 25, 2024
kylebonnici
added
doc not required
greg-fer
requested changes
Mar 25, 2024
Co-authored-by: Grzegorz Ferenc <[email protected]>
Co-authored-by: Grzegorz Ferenc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.