From d3e23f276dc56e74f962e7ba83cd8475c22330a8 Mon Sep 17 00:00:00 2001 From: kylebonnici Date: Tue, 2 Apr 2024 15:33:03 +0200 Subject: [PATCH 1/3] Feat: reduce severaty of battery dicsonnect event while profiling --- Changelog.md | 2 ++ src/components/Profiling/Dialog/ProfilingWizard.tsx | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Changelog.md b/Changelog.md index 4ed7b890..2138ddf3 100644 --- a/Changelog.md +++ b/Changelog.md @@ -3,6 +3,8 @@ ### Changed - Updated firmware to v1.1.1+0. +- Disconnected battery (vBat < 1V) while profiling this will only trigger a + warning. ### Removed diff --git a/src/components/Profiling/Dialog/ProfilingWizard.tsx b/src/components/Profiling/Dialog/ProfilingWizard.tsx index 4c8cd433..7f19fa63 100644 --- a/src/components/Profiling/Dialog/ProfilingWizard.tsx +++ b/src/components/Profiling/Dialog/ProfilingWizard.tsx @@ -223,7 +223,8 @@ export default () => { npmDevice?.getBatteryProfiler()?.stopProfiling(); dispatch( setCompleteStep({ - level: 'danger', + level: + profilingStage === 'Resting' ? 'danger' : 'warning', message: ` The profiling process was interrupted, as battery was disconnected while ${profilingStage}.`, }) ); From 4f1c549db67594bd6e0c0c9229ed59e043127ac6 Mon Sep 17 00:00:00 2001 From: Kyle Micallef Bonnici Date: Wed, 3 Apr 2024 10:15:47 +0200 Subject: [PATCH 2/3] Update Changelog.md Co-authored-by: Grzegorz Ferenc <41291385+greg-fer@users.noreply.github.com> --- Changelog.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Changelog.md b/Changelog.md index 2138ddf3..d54b491e 100644 --- a/Changelog.md +++ b/Changelog.md @@ -3,8 +3,7 @@ ### Changed - Updated firmware to v1.1.1+0. -- Disconnected battery (vBat < 1V) while profiling this will only trigger a - warning. +- During profiling, when a battery is considered disconnected (vBat < 1 V), a warning is now issued instead of a terminating error. ### Removed From ae13898a2182df4e4a3f5de4ffcc0f1feb3cf1b9 Mon Sep 17 00:00:00 2001 From: kylebonnici Date: Wed, 3 Apr 2024 10:36:43 +0200 Subject: [PATCH 3/3] Fix: lint --- Changelog.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Changelog.md b/Changelog.md index d54b491e..32feb72c 100644 --- a/Changelog.md +++ b/Changelog.md @@ -3,7 +3,8 @@ ### Changed - Updated firmware to v1.1.1+0. -- During profiling, when a battery is considered disconnected (vBat < 1 V), a warning is now issued instead of a terminating error. +- During profiling, when a battery is considered disconnected (vBat < 1 V), a + warning is now issued instead of a terminating error. ### Removed