Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removeAppender in JobSuite Exception #13

Open
kemcon opened this issue Jan 16, 2020 · 2 comments
Open

removeAppender in JobSuite Exception #13

kemcon opened this issue Jan 16, 2020 · 2 comments

Comments

@kemcon
Copy link

kemcon commented Jan 16, 2020

Hi,

i use your last RELEASE with collectorConfig.setLogsUnmanaged(true);

then i use the log4j-over-slf4j bridge, to manage the logging. and this bridge crashed in line 314 of JobSuite, because there is no removeAppender method:
314: Logger.getRootLogger().removeAppender(appender);

But, there is also no appender (=null), because of the new collectorConfig.setLogsUnmanaged(true); config. so please put a bugfix in your code, and move this line of code into to if (appender != null) one line above.

@essiembre
Copy link
Contributor

I was able to reproduce. Working on a fix.

@essiembre essiembre added the bug label Jan 21, 2020
essiembre added a commit that referenced this issue Jan 22, 2020
@essiembre
Copy link
Contributor

I applied the fix you suggested plus added more conditional checks that should make life easier for SLF4J users. Can you please replace the norconex-commons-lang-*.jar and norconex-jef-*.jar files you have with the following snapshots (or update your pom.xml accordingly if you use Maven):

norconex-commons-lang-1.15.2-SNAPSHOT

norconex-jef-4.1.3-SNAPSHOT

Let me know if that resolves your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants