Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create_connection() got an unexpected keyword argument 'loop' #212

Open
dmitrykaramin opened this issue Jan 31, 2022 · 0 comments · May be fixed by #214
Open

create_connection() got an unexpected keyword argument 'loop' #212

dmitrykaramin opened this issue Jan 31, 2022 · 0 comments · May be fixed by #214

Comments

@dmitrykaramin
Copy link

Checklist

  • Python version 3.10
  • Does issue exists against the master branch of aredis? Yes

Steps to reproduce

just run the code

Expected behavior

Expected connected to redis

Actual behavior

  • It is appreciated if error log can be provided

in your code

aredis/aredis/connection.py

Line 597 in b46e671

asyncio.open_connection(host=self.host,

you pass "loop" as an argument to asyncio.open_connection but this function in python 3.10 doesn't have this arg
MarSoft added a commit to MarSoft/aredis that referenced this issue Mar 31, 2022
@MarSoft
Don't pass loop arg to asyncio.open_connection
b512523 
Fix NoneGG#212. Required for Python 3.10+.
@MarSoft MarSoft linked a pull request Mar 31, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't pass loop arg to asyncio.open_connection MarSoft/aredis
1 participant
@dmitrykaramin