-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET Framework Support #11
Comments
Do you specifically need Framework 4.5? Would some netstandard target work? It might require a little effort since most of the internals use Span but probably not impossible. |
I believe that NET Standard 1.1 or 1.2 would work (as those reflect 4.5 and 4.5.1). I ended up implementing my own |
I'll see what I can do. (Also, nice cat.) |
Seems like ImageSharp (my dependency) only supports down to netstandard1.3. Would your project be able to upgrade to Framework 4.6 or 4.7? |
Unfortunately, no. It's a mod for a game that relies on XNA, so the framework is pretty locked. What is needed in ImageSharp? (He isn't in the room right now, but if he were he would respond probably by purring) |
ImageSharp is used for saving and loading standard image formats (jpg, png, tga..) and resizing the texture for mipmap creation. I am planning on replacing it with my own implementation eventually, but that's probably going to take a while. If you have another way of feeding RGBA-data to the library and don't need mipmaps, then creating a dependency-free fork for net45 might be possible. |
I don't need mipmaps, and I have zero use for standard formats. The input data is raw data (BGRA, RGBA, BGR, RGB), and I expect raw BCn results (I only need BC1/2/3). |
I'll whip up a stripped-down version for net45 tonight then. Might be up on nuget by tomorrow. I probably won't be maintaining that one as actively but it's there until I can get rid of ImageSharp. |
Hey, the net45 version is up on nuget now: https://www.nuget.org/packages/BCnEncoder.Net45 Input data needs to be as a byte array in rgba format and there is no mipmap generation. For getting raw compressed bytes you can use the If you use it and find anything lacking or something not working correctly, hit me up with another issue. |
I haven't had a chance to use it yet, I've been very busy at work and haven't had an opportunity to work on this project. |
Alright. Let me know if you do and need anything changed. For now I think this issue can be marked as closed. |
hey @Nominom , your library is very good, and i m trying to use it for my projects of reading game texture files i tried myself to convert the latest 2.1.0 version to .NET framework 4.7.2 (wich has support for .NET Standard 2.0) : if you would find time (and energy), |
Hi! I'm currently in the process of making version 3.0, which includes many major refactors and improvements. I could look into adding support for older .NET Standard versions in the same update. It would be quite a pain to manually import the new changes to the net45 branch since they are so different. I can't promise anything concrete for now, but I'll reopen this issue and keep you posted! |
yes, thanks, i ll keep an eye on the project for sure ! |
I just made a .NET standard 2.0 port (with minimal changes), in order to use it in .NET Framework 4.8 projects. And here is the myget package so you can use it now: Unit tests show 185/200 cases passed, so I guess maybe there are still something wrong? I should warn that I didn't measure the performance, and it should be very bad comparing to the original .NET standard 2.1 version, because I have to replace Nominom's carefully constructed high-performace span/memory codes to some very bad performance codes like |
Is it possible to support netstandard2.0? I'm trying to write an shell extension using shellsharp which only support net framework. I can't consume netstandard2.1 from net framework. |
Any chance you could add a build configuration for .NET Framework (preferably 4.5)?
The text was updated successfully, but these errors were encountered: