Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change ParseOutput::Tree to a Nonterminal instead of a Node #1184

Open
OmarTawfik opened this issue Dec 10, 2024 · 0 comments
Open

change ParseOutput::Tree to a Nonterminal instead of a Node #1184

OmarTawfik opened this issue Dec 10, 2024 · 0 comments
Assignees
@beta-ziliani

Comments

@OmarTawfik
Copy link
Contributor

Not blocking to this PR: IIUC, now any parse operation can return a Nonterminal, right?
I wonder if we should also change the type of ParseOutput::tree() from Node to Nonterminal. Users always pass a NonterminalKind to parse(), so it makes sense to expect a Nonterminal with the same kind back. Thoughts?

Originally posted by @OmarTawfik in #1172 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beta-ziliani beta-ziliani

Labels
None yet
Projects
Slang - 2024 H2
Status: ⏳ Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beta-ziliani @OmarTawfik