SVG zoom for visualization graph #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcuadrado
reviewed
Sep 23, 2024
kanej
reviewed
Sep 23, 2024
| @@ -31,6 +34,20 @@ export const Mermaid: React.FC<{ | |||
| mermaid.contentLoaded(); | |||
| }); | |||
|
|
|||
| // requestAnimationFrame is used to ensure that the svgPanZoom is called after the svg is rendered | |||
| useEffect(() => { | |||
| requestAnimationFrame(() => { | |||
There was a problem hiding this comment.
Can you walk me through this one.
Is the problem that you want to hold on the svgPanZoom invocation until you are sure that the diagram svg is rendered?
There was a problem hiding this comment.
Correct. If svgPanZoom is run before its rendered the function will error. This ensures that its run after rendering
|
I tried this manually and it works, but I added this for (let i = 1; i < 20; i++) {
basicContracts.push(
m.contractAt("BasicContract", basicContracts[i - 1], { id: "basic" + i })
);
}to
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #806
resolves #807
svg-pan-zoomlibrary to zoom and pan mermaid diagrammaxTextSizeto5e5instead of the default of5e4