Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using the result from m.staticCall or m.readEventArgument as value option #478

Merged
merged 5 commits into from
Sep 20, 2023

Conversation

zoeyTM
Copy link
Contributor

@zoeyTM zoeyTM commented Sep 19, 2023

fixes #455

typeof moduleParam === "bigint",
"Module parameter used as value must be a bigint"
typeof result === "bigint",
"Module parameter or future result used as value must be a bigint"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nicely done.

@kanej kanej merged commit 88b3294 into development Sep 20, 2023
6 checks passed
@kanej kanej deleted the feat/expand-value branch September 20, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Expand value and from to support staticCall/readEventArg
2 participants