feat: store debug files with build infos #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanej
commented
Sep 14, 2023
packages/core/src/internal/deployment-loader/file-deployment-loader.ts
Outdated
Show resolved
Hide resolved
kanej
changed the title
kanej
commented
Sep 14, 2023
alcuadrado
approved these changes
Sep 14, 2023
kanej
force-pushed
the
feat/dbg-files
branch
from
d3a1b25 to
9f271cb
Compare
If a build info is stored for a future id, record a debug file as a pointer. The debug file is a sibling to the artifact file, so under `./ignition/deployments/<depid>/artifacts`: - `LockModule#Lock.json` - `LockModule#Lock.dbg.json` The dbg file points at the Ignition build info file via a relative path. Resolves #472.
kanej
force-pushed
the
feat/dbg-files
branch
from
9f271cb to
60805a7
Compare
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a build info is stored for a future id, record a debug file as a pointer. The debug file is a sibling to the artifact file, so under
./ignition/deployments/<depid>/artifacts:LockModule#Lock.jsonLockModule#Lock.dbg.jsonThe dbg file points at the Ignition build info file via a relative path.