feat: rename plan to visualize #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanej
force-pushed
the
refactor/rework-plan-to-visualize
branch
2 times, most recently
from
595aba6 to
b0aaa04
Compare
|
We have opted to not export visualize from core for the moment. Instead the visualize task will only leverage the The serializer has been tightened up to only be about IgnitionModules. |
kanej
force-pushed
the
refactor/rework-plan-to-visualize
branch
from
b0aaa04 to
a7f6071
Compare
alcuadrado
approved these changes
Sep 14, 2023
We intend to support viewing an already run deployment, hence plan makes less sense. Instead we will go with the more generic visualize for the moment.
Replace the deployment serializer with just an IgnitionModule serializer.
For the moment, remove the visualize function from the public core api. Out intent is to bring this back, returning the full deployment result type so that a visualization can show the current journaled state of a deployment. This will be additative to the api.
kanej
force-pushed
the
refactor/rework-plan-to-visualize
branch
from
a7f6071 to
656f22d
Compare
The chainId check test needs to read an existing deployment, the startup time seems to trip the timeout.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We intend to support viewing an already run deployment, hence plan makes less sense. Instead we will go with the more generic visualize for the moment.
Resolves #450
TODO
visualize(or show)?Change the result type to match as much of deploy as makes sense (validation fails, reconciliation fails, execution results)