refactor: rename wipe message #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the `WIPE_EXECUTION_STATE` message to `WIPE_APPLY`. This is because all other message follow a `NOUN_VERB_MESSAGE` structure, so we should follow it for wipe as well. The problem with mentioning execution state is it suggests that we are dealing with a execution state level message. In reality `WIPE` is its own world.
kanej
force-pushed
the
refactor/message-renames
branch
from
33b2ec2 to
0cc420a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the
WIPE_EXECUTION_STATEmessage toWIPE_APPLY. This is because all other message follow aNOUN_VERB_MESSAGEstructure, so we should follow it for wipe as well.The problem with mentioning execution state is it suggests that we are dealing with a execution state level message. In reality
WIPEis its own world.