Format the execution errors returned by deploy() #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the result self-contained.
alcuadrado
force-pushed
the
error-messages-format
branch
from
1dfca5a to
87b89cd
Compare
kanej
reviewed
Aug 30, 2023
| export { | ||
| StoredDeploymentDeserializer, | ||
| StoredDeploymentSerializer, | ||
| } from "./new-api/stored-deployment-serializer"; | ||
| export * from "./new-api/type-guards"; | ||
| export * from "./new-api/types/module"; | ||
| export * from "./new-api/types/serialized-deployment"; | ||
| export { formatSolidityParameter } from "./new-api/internal/formatters"; |
There was a problem hiding this comment.
Just so I am clear on the reasoning.
Because this will inevitable be used in both the UI project and the cli, we move it to core and leverage it from there; as the alternative is duplication?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #410 and #426