-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring back UI for execution #401
Conversation
0c38d68
to
cff68f4
Compare
cff68f4
to
48a2637
Compare
Great progress! Good idea to start with the verbose logging listener. Now that we decided to have independent I think this would mean emitting them in:
Also, how annoying is it to have to use this weird syntax? public [ExecutionEventType.RUN_START](event: RunStartEvent): void {
// ....
} |
@alcuadrado ah okay, i can update that! As for the weird syntax, we don't technically have to do it that way. We could also do public RUN_START(event: RunStartEvent): void {
// ....
} I just did it the current way because I figured it was one less thing we have to update if we ever change one of the enum values but maybe I'm overthinking it. Now that I'm typing this out, though, I'm thinking there's not really a reason besides convention that we couldn't do something like: export enum ExecutionEventType {
RUN_START = "runStart",
WIPE_EXECUTION_STATE = "wipeExecutionStart",
// etc...
} which would make the handler functions just normal function names. Thoughts? |
packages/hardhat-plugin/src/ui/components/execution/FinalStatus.tsx
Outdated
Show resolved
Hide resolved
Switched out the usage of flat to the core function. Added in doc comments to meet api-extractor rules.
On a rerun no batches are executed. Show the deployed addresses anyway. This involved adding a deployment complete event, that passes the deployment result. This will be extended to failure cases in future commits.
Instead of showing all batches at once. Only display a batch if at least one future has started (excluding the first batch). We may want to enhance this by tracking the current batch in the ui based on the batch events.
fixes #259