Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viem support #589

Closed
2 tasks done
kanej opened this issue Oct 24, 2023 · 3 comments
Closed
2 tasks done

viem support #589

kanej opened this issue Oct 24, 2023 · 3 comments
Labels
type:epic A bigger effort that involves multiple issues and PRs type:feature Fetaure request

Comments

@kanej
Copy link
Member

kanej commented Oct 24, 2023

Hardhat Ignition can be used in tests and scripts to deploy modules, the deploy function returns the contract instances as Ethers v6 contract objects. With the release of viem support in Hardhat, we should also support the option of returning viem contract objects.

We need to determine the build and release strategy to support a viem version of Ignition. We should also evaluate any other implications to viem usage with Ignition.

TODO

@kanej kanej added this to the v1.0.0 milestone Oct 24, 2023
@kanej kanej added status:ready This issue is ready to be worked on type:feature Fetaure request and removed status:triaging labels Oct 24, 2023
@kanej kanej moved this to Todo in Hardhat Ignition Oct 24, 2023
@kanej kanej removed the status in Hardhat Ignition Oct 24, 2023
@kanej kanej added type:epic A bigger effort that involves multiple issues and PRs and removed status:ready This issue is ready to be worked on labels Oct 26, 2023
@kanej kanej modified the milestones: v1.0.0, v0.12.0 Release Oct 26, 2023
@wighawag
Copy link

wighawag commented Nov 6, 2023

Just stumbled on this while looking at the open issues, and though might give some feedback :)

Why do you not make hardhat-ignition agnostic ?

hardhat-deploy let user use any lib they want. a deployment is basically a an artifact + address.

you can always add wrapper to make it more convenient. for hardhat-deploy, there is hardhat-deploy-ethers. you could follow a similar strategy

@kanej
Copy link
Member Author

kanej commented Nov 7, 2023

Just stumbled on this while looking at the open issues, and though might give some feedback :)

Why do you not make hardhat-ignition agnostic ?

hardhat-deploy let user use any lib they want. a deployment is basically a an artifact + address.

you can always add wrapper to make it more convenient. for hardhat-deploy, there is hardhat-deploy-ethers. you could follow a similar strategy

I think this is the path we will go down. With a hardhat-ignition package that only provides cli support, and extension packages that you can opt into for ethers/viem support in tests and scripts.

@kanej
Copy link
Member Author

kanej commented Dec 14, 2023

Released as part of v0.13.0. We separated out @nomicfoundation/hardhat-ignition from @nomicfoundation/hardhat-ignition-ethers, and added @nomicfoundation/hardhat-ignition-viem.

See our Viem guide for more details: https://hardhat.org/ignition/docs/guides/viem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:epic A bigger effort that involves multiple issues and PRs type:feature Fetaure request
Projects
Archived in project
Development

No branches or pull requests

2 participants