Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit library use in calls #454

Closed
kanej opened this issue Sep 11, 2023 · 0 comments · Fixed by #461
Closed

Limit library use in calls #454

kanej opened this issue Sep 11, 2023 · 0 comments · Fixed by #461
Assignees
@zoeyTM
Labels
status:ready This issue is ready to be worked on type:chore A task related to code quality, tooling, CI, or anthing that doesn't directly impact the end users
Milestone
Beta v0.4.0

Comments

@kanej
Copy link
Member

kanej commented Sep 11, 2023

Call and staticCall allow calls on libraries. We should consider, limiting the api only to contracts.
@kanej kanej moved this to Todo in Hardhat Ignition Sep 11, 2023
@kanej kanej added this to the Beta v0.4.0 milestone Sep 11, 2023
@kanej kanej added type:chore A task related to code quality, tooling, CI, or anthing that doesn't directly impact the end users status:ready This issue is ready to be worked on and removed status:triaging labels Sep 11, 2023
@zoeyTM zoeyTM self-assigned this Sep 12, 2023
@zoeyTM zoeyTM moved this from Todo to In Progress in Hardhat Ignition Sep 12, 2023
@zoeyTM zoeyTM mentioned this issue Sep 12, 2023
Merged
@zoeyTM zoeyTM moved this from In Progress to In Review in Hardhat Ignition Sep 12, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Hardhat Ignition Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zoeyTM zoeyTM

Labels
status:ready This issue is ready to be worked on type:chore A task related to code quality, tooling, CI, or anthing that doesn't directly impact the end users
Projects
Hardhat Ignition
Archived in project
Milestone
Beta v0.4.0
Development

Successfully merging a pull request may close this issue.

restrict calls and static calls to non library contracts NomicFoundation/hardhat-ignition
2 participants
@kanej @zoeyTM