Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor strategy to work in terms of future #453

Open
kanej opened this issue Sep 11, 2023 · 2 comments
Open

Refactor strategy to work in terms of future #453

kanej opened this issue Sep 11, 2023 · 2 comments
Labels
status:ready This issue is ready to be worked on type:chore A task related to code quality, tooling, CI, or anthing that doesn't directly impact the end users

Comments

@kanej
Copy link
Member

kanej commented Sep 11, 2023

Analyze execution strategy to see if we can swap future for exState in the strategy interface. This will significantly reduce our exposed public api surface area.
@kanej kanej added this to the Beta v0.4.0 milestone Sep 11, 2023
@kanej kanej added type:chore A task related to code quality, tooling, CI, or anthing that doesn't directly impact the end users status:ready This issue is ready to be worked on and removed status:triaging labels Sep 11, 2023
@kanej kanej moved this to Todo in Hardhat Ignition Sep 11, 2023
@kanej kanej self-assigned this Sep 11, 2023
@kanej kanej moved this from Todo to In Progress in Hardhat Ignition Sep 11, 2023
@kanej
Copy link
Member Author

kanej commented Sep 11, 2023

Digging into this, I am not sure we can just use futures instead of exStates. Execution states have been resolved down to base values, we would be moving the resolution onto the execution strategy if we inject future.

Futures don't currently have an artifactId either.

Image

@kanej kanej moved this from In Progress to Blocked in Hardhat Ignition Sep 11, 2023
@kanej
Copy link
Member Author

kanej commented Sep 13, 2023

We are moving this to the beta follow on. We will tackle it with the create2 work.

@kanej kanej removed their assignment Oct 24, 2023
@kanej kanej removed this from the Public beta followup milestone Oct 24, 2023
@kanej kanej mentioned this issue Oct 24, 2023
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on type:chore A task related to code quality, tooling, CI, or anthing that doesn't directly impact the end users
Projects
Hardhat Ignition
Status: Blocked
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kanej