Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate module names and actions ids #441

Closed
kanej opened this issue Sep 8, 2023 · 0 comments · Fixed by #466
Closed

validate module names and actions ids #441

kanej opened this issue Sep 8, 2023 · 0 comments · Fixed by #466
Assignees
@kanej
Labels
status:ready This issue is ready to be worked on type:improvement An enhancement to an existing feature
Milestone
Beta v0.4.0

Comments

@kanej
Copy link
Member

kanej commented Sep 8, 2023 •
edited
Loading

We are currently allowing any string. We should define a set of identifier rules and validation for them.

Also add a debug file.
@kanej kanej moved this to Todo in Hardhat Ignition Sep 8, 2023
@kanej kanej added status:ready This issue is ready to be worked on type:improvement An enhancement to an existing feature and removed status:triaging labels Sep 8, 2023
@kanej kanej added this to the Beta v0.4.0 milestone Sep 11, 2023
@kanej kanej self-assigned this Sep 11, 2023
@kanej kanej moved this from Todo to In Progress in Hardhat Ignition Sep 12, 2023
@kanej kanej moved this from In Progress to In Review in Hardhat Ignition Sep 13, 2023
kanej added a commit that referenced this issue Sep 13, 2023
@kanej
feat: change id separators
9d503d5 
Modify our id separators, swapping:

- `:` => `#`
- `#` => `.`

This allows us to write the identifiers as filenames on windows.

Resolves #441.
kanej added a commit that referenced this issue Sep 13, 2023
@kanej
feat: change id separators
8e459a0 
Modify our id separators, swapping:

- `:` => `#`
- `#` => `.`

This allows us to write the identifiers as filenames on windows.

Resolves #441.
kanej added a commit that referenced this issue Sep 13, 2023
@kanej
feat: change id separators
9e93069 
Modify our id separators, swapping:

- `:` => `#`
- `#` => `.`

This allows us to write the identifiers as filenames on windows.

Resolves #441.
@kanej kanej linked a pull request Sep 13, 2023 that will close this issue
feat/constrain-ids #466
Merged
kanej added a commit that referenced this issue Sep 14, 2023
@kanej
feat: change id separators
ba6d5bc 
Modify our id separators, swapping:

- `:` => `#`
- `#` => `.`

This allows us to write the identifiers as filenames on windows.

Resolves #441.
kanej added a commit that referenced this issue Sep 14, 2023
@kanej
feat: change id separators
a0ee590 
Modify our id separators, swapping:

- `:` => `#`
- `#` => `.`

This allows us to write the identifiers as filenames on windows.

Resolves #441.
@github-project-automation github-project-automation bot moved this from In Review to Done in Hardhat Ignition Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kanej kanej

Labels
status:ready This issue is ready to be worked on type:improvement An enhancement to an existing feature
Projects
Hardhat Ignition
Archived in project
Milestone
Beta v0.4.0
Development

Successfully merging a pull request may close this issue.

feat/constrain-ids NomicFoundation/hardhat-ignition
1 participant
@kanej