Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reconciliation fail after successful send #420

Closed
kanej opened this issue Aug 28, 2023 · 0 comments · Fixed by #427
Closed

reconciliation fail after successful send #420

kanej opened this issue Aug 28, 2023 · 0 comments · Fixed by #427
Assignees
@kanej
Labels
status:ready This issue is ready to be worked on type:bug Something isn't working
Milestone
Alpha v0.3.0

Comments

@kanej
Copy link
Member

kanej commented Aug 28, 2023

The reconciliation rules are too tight for send. A successful send on rerun fails in comparing the undefined data to '0x'

image

Steps to reproduce

Run the complete example against a local node:

cd ./examples/complete
npx hardhat node
# in another window
npx hardhat deploy ./ignition/CompleteModule.js --network localhost
@kanej kanej added the type:bug Something isn't working label Aug 28, 2023
@kanej kanej added this to the Alpha v0.3.0 milestone Aug 28, 2023
@kanej kanej added status:ready This issue is ready to be worked on and removed status:triaging labels Aug 28, 2023
@kanej kanej moved this to Todo in Hardhat Ignition Aug 28, 2023
@kanej kanej moved this from Todo to In Progress in Hardhat Ignition Aug 29, 2023
@kanej kanej self-assigned this Aug 29, 2023
kanej added a commit that referenced this issue Aug 29, 2023
@kanej
fix: reconcile send data when undefined
805b6c9 
Two runs where the send data is undefined now reconcile.

Fixes #420.
@kanej kanej mentioned this issue Aug 29, 2023
Merged
@kanej kanej moved this from In Progress to In Review in Hardhat Ignition Aug 29, 2023
kanej added a commit that referenced this issue Aug 29, 2023
@kanej
fix: reconcile send data when undefined
b4de520 
Two runs where the send data is undefined now reconcile.

Fixes #420.
@github-project-automation github-project-automation bot moved this from In Review to Done in Hardhat Ignition Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kanej kanej

Labels
status:ready This issue is ready to be worked on type:bug Something isn't working
Projects
Hardhat Ignition
Archived in project
Milestone
Alpha v0.3.0
Development

Successfully merging a pull request may close this issue.

fix: reconcile send data when undefined NomicFoundation/hardhat-ignition
1 participant
@kanej