Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove console.log backwards compatibility tests #706

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Oct 22, 2024

This PR fixes broken test files due to the upgrade to the latest Hardhat. These files were already removed in Hardhat in this PR: NomicFoundation/hardhat#5764

@Wodann Wodann added the no changeset needed This PR doesn't require a changeset label Oct 22, 2024
@Wodann Wodann requested a review from agostbiro October 22, 2024 05:52
@Wodann Wodann self-assigned this Oct 22, 2024
Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: f057558

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Wodann Wodann had a problem deploying to github-action-benchmark October 22, 2024 05:52 — with GitHub Actions Failure
@Wodann Wodann changed the title Feat/merge multichain Merge 'main' into feat/multichain Oct 22, 2024
@Wodann Wodann force-pushed the feat/merge-multichain branch from 34eb49a to 04cb6c0 Compare October 22, 2024 05:59
@Wodann Wodann had a problem deploying to github-action-benchmark October 22, 2024 05:59 — with GitHub Actions Failure
@Wodann Wodann force-pushed the feat/merge-multichain branch from 04cb6c0 to 7be20ca Compare October 22, 2024 06:01
@Wodann Wodann had a problem deploying to github-action-benchmark October 22, 2024 06:02 — with GitHub Actions Failure
@Wodann Wodann force-pushed the feat/merge-multichain branch from 7be20ca to 8b56d89 Compare October 22, 2024 06:03
@Wodann Wodann had a problem deploying to github-action-benchmark October 22, 2024 06:03 — with GitHub Actions Failure
@Wodann Wodann force-pushed the feat/merge-multichain branch from 8b56d89 to d0b282c Compare October 22, 2024 06:07
@Wodann Wodann had a problem deploying to github-action-benchmark October 22, 2024 06:07 — with GitHub Actions Failure
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.51%. Comparing base (ec3c837) to head (f057558).
Report is 1 commits behind head on feat/multichain.

Additional details and impacted files
@@               Coverage Diff                @@
##           feat/multichain     #706   +/-   ##
================================================
  Coverage            53.51%   53.51%           
================================================
  Files                  236      236           
  Lines                27743    27743           
  Branches             27743    27743           
================================================
  Hits                 14847    14847           
  Misses               11977    11977           
  Partials               919      919           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wodann Wodann force-pushed the feat/merge-multichain branch from d0b282c to ec3c837 Compare October 22, 2024 06:34
@Wodann Wodann temporarily deployed to github-action-benchmark October 22, 2024 06:34 — with GitHub Actions Inactive
@Wodann Wodann temporarily deployed to github-action-benchmark October 22, 2024 07:22 — with GitHub Actions Inactive
Copy link
Member

@agostbiro agostbiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@Wodann Wodann changed the title Merge 'main' into feat/multichain fix: remove console.log backwards compatibility tests Oct 23, 2024
@Wodann Wodann merged commit e977cf2 into feat/multichain Oct 23, 2024
41 checks passed
@Wodann Wodann deleted the feat/merge-multichain branch October 23, 2024 00:12
@Wodann
Copy link
Member Author

Wodann commented Oct 23, 2024

I ended up pushing the merge commit separately as the "squash and merge" option has previously caused negative side-effects by erasing the merge commit. As a result, git becomes confused about what the base commit of this branch is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants