Eager Loading

[jacaetevha]

Would it be acceptable to add options for doing eager loading when logging in a user?

E.g.

def find_by_credentials(*credentials)
  # ...
  arel = @klass.where(relation)
  arel = arel.includes(@eager_loading_options) if @eager_loading_options.present?
  arel.first
end

config.user_config do |user|
  user.eager_loading = {things: {other_things: [:then, :that, :stuff]}}
end

[arnvald]

Hi @jacaetevha,

thanks for suggestion. I don't think we should add this, though. The main reason is that it goes beyond the scope of Sorcery - it has nothing to do with authentication. Another reason is that there are a few places where user model is loaded - not only find_by_credentials but also load_from_provider, find_by_token etc, so adding this would add a lot of complexity.

[ivanreese]

I'd also like to be able to use includes to do eager loading with the current_user, to load (for instance) associated permissions used for authorization.

The pull request for adding a scope_for_authentication seems like it'd support this use case: #727